Bigtable: make client settings more consistent #4498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eventual goal is to deemphasize per method RPC settings by relegating them to stubSettings. And promote more common settings like credentials to the top level. This breaks backwards compatibility by removing BigtableDataSettings' base class. It tries to ease the transition by copying the ClientSettings methods down into BigtableDataSettings. Specific changes: - BigtableDataSettings is no longer a subclass of ClientSettings - ClientSettings methods have been temporarily copied to BigtableDataSettings with deprecation warnings to ease transition - add helper method to ease connection to emulator - make sure that credential provider is configurable at the top level (fixes googleapis#3634) - all of the deprecated methods have been grouped together and will be removed in the next couple of releases (along with the deprecated google-bigtable-admin artifact)
googlebot
added
the
cla: yes
igorbernstein2
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #4498 +/- ##
============================================
- Coverage 49.16% 49.15% -0.02%
- Complexity 21915 21917 +2
============================================
Files 2078 2078
Lines 207084 207152 +68
Branches 24084 24084
============================================
+ Hits 101815 101818 +3
- Misses 97126 97191 +65
Partials 8143 8143
Continue to review full report at Codecov.
|
|
@igorbernstein2, it looks like all tests are failing now. |
# Conflicts: # google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ResourceHeaderTest.java
|
I think it was just a merge conflict |
sduskis
reviewed
Feb 15, 2019
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventual goal is to deemphasize per method RPC settings by relegating them to stubSettings. And promote more common settings like credentials to the top level.
This breaks backwards compatibility by removing BigtableDataSettings' base class. It tries to ease the transition by copying the ClientSettings methods down into BigtableDataSettings.
Specific changes:
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)