Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: integrate OpenCensus tracing into the bigtable data client #4493

Merged
merged 12 commits into from
Feb 26, 2019

Conversation

igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Feb 14, 2019

This adds instrumentation from gax-java to enable tracing of the Bigtable client data operations.

@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Feb 14, 2019
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner February 14, 2019 19:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2019
@igorbernstein2
Copy link
Author

example trace

@sduskis sduskis added the status: blocked Resolving the issue is dependent on other work. label Feb 20, 2019
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #4493 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4493      +/-   ##
============================================
+ Coverage     49.15%   49.19%   +0.04%     
- Complexity    21940    21970      +30     
============================================
  Files          2077     2077              
  Lines        207215   207440     +225     
  Branches      24108    24107       -1     
============================================
+ Hits         101861   102058     +197     
- Misses        97180    97206      +26     
- Partials       8174     8176       +2
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 98.61% <100%> (+0.04%) 17 <0> (ø) ⬇️
...v2/stub/mutaterows/MutateRowsRetryingCallable.java 92.85% <100%> (ø) 2 <0> (ø) ⬇️
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 98.47% <100%> (+0.12%) 22 <5> (+2) ⬆️
...ud/bigtable/gaxx/tracing/WrappedTracerFactory.java 100% <100%> (ø) 2 <2> (?)
.../v2/stub/mutaterows/MutateRowsAttemptCallable.java 89.1% <100%> (+0.33%) 19 <0> (ø) ⬇️
.../com/google/cloud/redis/v1/CloudRedisSettings.java 12.72% <0%> (-3.56%) 2% <0%> (ø)
...com/google/cloud/redis/v1/stub/CloudRedisStub.java 5.88% <0%> (-3.21%) 1% <0%> (ø)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 83.46% <0%> (-0.81%) 49% <0%> (ø)
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 78.63% <0%> (-0.36%) 27% <0%> (-1%)
...bigtable/admin/v2/BigtableInstanceAdminClient.java 97.09% <0%> (-0.03%) 45% <0%> (-1%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee8aa1...8c1a89c. Read the comment docs.

@igorbernstein2 igorbernstein2 changed the title WIP: Bigtable: integrate OpenCensus tracing into the bigtable data client Bigtable: integrate OpenCensus tracing into the bigtable data client Feb 22, 2019
@igorbernstein2 igorbernstein2 removed the status: blocked Resolving the issue is dependent on other work. label Feb 22, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 22, 2019
dependencies and configure an exporter. For example to enable tracing using
[Google Stackdriver](https://cloud.google.com/trace/docs/):

[//]: # (TODO: figure out how to keep opencensus version in sync with pom.xml)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to ensure that the opencensus versions in this readme stay up to date with google-cloud-clients/pom.xml properties. I thought about using version markers, but those seem to only be used for internal artifacts. It would be awesome if version.txt could be generalized to manage static external versions as well.

@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2019
@sduskis
Copy link
Contributor

sduskis commented Feb 25, 2019

Kokoro - Test: Code Format failed.

@igorbernstein2
Copy link
Author

Format fixed

@igorbernstein2 igorbernstein2 merged commit 41a04ee into googleapis:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants