Fix checkstyle issues and warnings #446

ajkannan · 2015-12-10T01:55:55Z

No description provided.

gcloud-java-core/src/main/java/com/google/gcloud/PageImpl.java

@@ -71,6 +71,7 @@ public PageImpl(NextPageFetcher<T> pageFetcher, String cursor, Iterable<T> resul
    this.results = results;
  }

+  @SuppressWarnings("unchecked")


aozarov · 2015-12-10T03:13:45Z

Great. Thanks for doing that. Few nits.

gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

@@ -53,6 +53,7 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;

+@SuppressWarnings("rawtypes")


ajkannan · 2015-12-10T18:06:41Z

Added a commit to address all the comments thus far

Fix checkstyle issues and warnings

…onfig to v0.11.1 (googleapis#446) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `0.11.0` -> `0.11.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.11.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.11.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.11.1/compatibility-slim/0.11.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.11.1/confidence-slim/0.11.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v0.11.1`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#0111-httpswwwgithubcomgoogleapisjava-shared-configcomparev0110v0111-2021-04-14) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.11.0...v0.11.1) </details> --- ### Configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).

…onfig to v1.3.3 (#446) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.3.2` -> `1.3.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.3/compatibility-slim/1.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.3/confidence-slim/1.3.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.3.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#133-httpsgithubcomgoogleapisjava-shared-configcomparev132v133-2022-04-19) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.3.2...v1.3.3) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).

🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/java-assured-workloads@v1.1.0...v2.0.0) (2022-07-01) ### ⚠ BREAKING CHANGES * proto file name is changed from assuredworkloads_v1beta1.proto to assuredworkloads.proto ### Features * Enable REST transport for most of Java and Go clients ([googleapis#448](googleapis/java-assured-workloads#448)) ([2ec7bb4](googleapis/java-assured-workloads@2ec7bb4)) * ITAR June Preview Launch ([googleapis#453](googleapis/java-assured-workloads#453)) ([eeed2fd](googleapis/java-assured-workloads@eeed2fd)) * Removed _v1beta1 suffix from proto file names ([googleapis#443](googleapis/java-assured-workloads#443)) ([853eb5b](googleapis/java-assured-workloads@853eb5b)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#450](googleapis/java-assured-workloads#450)) ([c115d5f](googleapis/java-assured-workloads@c115d5f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#447](googleapis/java-assured-workloads#447)) ([3b07e54](googleapis/java-assured-workloads@3b07e54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-plugin to v3.4.1 (#446) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-analytics-admin).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-api-core](https://togithub.com/googleapis/python-api-core) | `==2.8.2` -> `==2.10.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).

fix checkstyle issues and warnings

c36b857

ajkannan added the type: cleanup An internal cleanup or hygiene concern. label Dec 10, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2015

aozarov reviewed Dec 10, 2015
View reviewed changes

gcloud-java-core/src/main/java/com/google/gcloud/PageImpl.java

@@ -71,6 +71,7 @@ public PageImpl(NextPageFetcher<T> pageFetcher, String cursor, Iterable<T> resul

this.results = results;

}

@SuppressWarnings("unchecked")

This comment was marked as spam.

Sign in to view

eamonnmcmanus reviewed Dec 10, 2015
View reviewed changes

gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

@@ -53,6 +53,7 @@

import java.util.regex.Matcher;

import java.util.regex.Pattern;

@SuppressWarnings("rawtypes")

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Add generic type to ServiceOption definition + minor fixes

d0eec71

aozarov added a commit that referenced this pull request Dec 10, 2015

Merge pull request #446 from ajkannan/fix-checkstyle-errors

21d985c

Fix checkstyle issues and warnings

aozarov merged commit 21d985c into googleapis:master Dec 10, 2015

ajkannan deleted the fix-checkstyle-errors branch December 10, 2015 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix checkstyle issues and warnings #446

Fix checkstyle issues and warnings #446

ajkannan commented Dec 10, 2015

This comment was marked as spam.

aozarov commented Dec 10, 2015

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Dec 10, 2015

Fix checkstyle issues and warnings #446

Fix checkstyle issues and warnings #446

Conversation

ajkannan commented Dec 10, 2015

This comment was marked as spam.

aozarov commented Dec 10, 2015

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Dec 10, 2015