Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove http initializer from AuthCredentials #430

Merged
merged 6 commits into from
Dec 2, 2015
Merged

Remove http initializer from AuthCredentials #430

merged 6 commits into from
Dec 2, 2015

Conversation

ajkannan
Copy link

@ajkannan ajkannan commented Dec 1, 2015

Fixes #403. This PR also removes the dependency on com.google.api.client.googleapis.auth.oauth2.GoogleCredential

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2015
Remove dependency on http initializer in AuthCredentials and remove d…
57d6e3f 
…ependency on com.google.api.client.googleapis.auth.oauth2.GoogleCredential
@ajkannan ajkannan force-pushed the remove-initializer-dependency branch from 7b1373d to 57d6e3f Compare December 1, 2015 16:38
@ajkannan ajkannan force-pushed the remove-initializer-dependency branch from 499e823 to b5c1cae Compare December 1, 2015 17:48
aozarov
aozarov reviewed Dec 1, 2015
View reviewed changes
gcloud-java-core/src/main/java/com/google/gcloud/AuthCredentials.java
GoogleCredential tempCredentials = GoogleCredential.fromStream(jsonCredentialStream);
return new ServiceAccountAuthCredentials(tempCredentials.getServiceAccountId(),
tempCredentials.getServiceAccountPrivateKey());
GoogleCredentials tempCredentials = GoogleCredentials.fromStream(jsonCredentialStream);

This comment was marked as spam.

Sign in to view

@ajkannan ajkannan force-pushed the remove-initializer-dependency branch from a6bfd48 to 68e3de9 Compare December 1, 2015 22:21
@ajkannan ajkannan added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 1, 2015
@ajkannan
Copy link
Author

ajkannan commented Dec 1, 2015

@aozarov comments incorporated

Added a don't merge label because this still has to be tested on all the platforms.

@ajkannan ajkannan force-pushed the remove-initializer-dependency branch 4 times, most recently from 1a050e0 to 78667fa Compare December 1, 2015 22:48
@ajkannan ajkannan force-pushed the remove-initializer-dependency branch from 78667fa to 12078e0 Compare December 1, 2015 22:50
@ajkannan ajkannan force-pushed the remove-initializer-dependency branch from 8c7c96a to af94b53 Compare December 1, 2015 23:36
@aozarov
Copy link
Contributor

aozarov commented Dec 2, 2015

LGTM, feel free to merge (and remove label) after you verified.

@ajkannan ajkannan removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 2, 2015
@ajkannan
Copy link
Author

ajkannan commented Dec 2, 2015

Test app runs on all platforms without problems, will merge in now.

ajkannan added a commit that referenced this pull request Dec 2, 2015
@ajkannan
Merge pull request #430 from ajkannan/remove-initializer-dependency
ab8ca97 
Remove http initializer from AuthCredentials
@ajkannan ajkannan merged commit ab8ca97 into googleapis:master Dec 2, 2015
@ajkannan ajkannan deleted the remove-initializer-dependency branch December 2, 2015 01:04
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
252174a 
…cies to v2.13.0 (#430)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.12.0` -> `2.13.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/compatibility-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/confidence-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v2.13.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#&#8203;2130-httpsgithubcomgoogleapisjava-shared-dependenciescomparev2120v2130-2022-06-22)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.12.0...v2.13.0)

##### Dependencies

-   update dependency com.google.api-client:google-api-client-bom to v1.35.0 ([#&#8203;709](https://togithub.com/googleapis/java-shared-dependencies/issues/709)) ([239f8c3](https://togithub.com/googleapis/java-shared-dependencies/commit/239f8c33a11e233e6af79aee8c7e68cd156a0554))
-   update dependency com.google.api-client:google-api-client-bom to v1.35.1 ([#&#8203;713](https://togithub.com/googleapis/java-shared-dependencies/issues/713)) ([6559b45](https://togithub.com/googleapis/java-shared-dependencies/commit/6559b45b027dba783a9525d35e32183d78773cbe))
-   update dependency com.google.api:api-common to v2.2.1 ([#&#8203;710](https://togithub.com/googleapis/java-shared-dependencies/issues/710)) ([650d4c5](https://togithub.com/googleapis/java-shared-dependencies/commit/650d4c5f8c3cfce711257d47280ad773cd2e2414))
-   update dependency com.google.errorprone:error_prone_annotations to v2.14.0 ([#&#8203;701](https://togithub.com/googleapis/java-shared-dependencies/issues/701)) ([d24730f](https://togithub.com/googleapis/java-shared-dependencies/commit/d24730f78669f80b109e590b903446e5552e3e36))
-   update dependency com.google.http-client:google-http-client-bom to v1.42.0 ([#&#8203;711](https://togithub.com/googleapis/java-shared-dependencies/issues/711)) ([5168a18](https://togithub.com/googleapis/java-shared-dependencies/commit/5168a181722128d434a0d0d2ab5cc485686bbc78))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.0 ([#&#8203;708](https://togithub.com/googleapis/java-shared-dependencies/issues/708)) ([620336e](https://togithub.com/googleapis/java-shared-dependencies/commit/620336e6733e2017116e5e8a7b403b183a728bc1))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.1 ([#&#8203;712](https://togithub.com/googleapis/java-shared-dependencies/issues/712)) ([a2c18a5](https://togithub.com/googleapis/java-shared-dependencies/commit/a2c18a5bc4152cc9034cec691a29f54a35c38a51))
-   update dependency com.google.protobuf:protobuf-bom to v3.21.0 ([#&#8203;703](https://togithub.com/googleapis/java-shared-dependencies/issues/703)) ([5f9fe12](https://togithub.com/googleapis/java-shared-dependencies/commit/5f9fe1200b4bdf4c54bf947c21bd3ed02f26f990))
-   update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#&#8203;705](https://togithub.com/googleapis/java-shared-dependencies/issues/705)) ([c68edfb](https://togithub.com/googleapis/java-shared-dependencies/commit/c68edfbe7e1993e1112640b867b29aa2fbcf7579))
-   update dependency io.grpc:grpc-bom to v1.47.0 ([#&#8203;707](https://togithub.com/googleapis/java-shared-dependencies/issues/707)) ([d02918a](https://togithub.com/googleapis/java-shared-dependencies/commit/d02918a0418cd65d1d247f27afb0637f1f8f5666))
-   update dependency org.checkerframework:checker-qual to v3.22.1 ([#&#8203;706](https://togithub.com/googleapis/java-shared-dependencies/issues/706)) ([545843b](https://togithub.com/googleapis/java-shared-dependencies/commit/545843b492cead230b8cc72a1dae7d4922f33b39))
-   update dependency org.checkerframework:checker-qual to v3.22.2 ([#&#8203;717](https://togithub.com/googleapis/java-shared-dependencies/issues/717)) ([142852a](https://togithub.com/googleapis/java-shared-dependencies/commit/142852a37140f221197f5c71aed451def353b1e0))
-   update gax.version to v2.18.2 ([#&#8203;718](https://togithub.com/googleapis/java-shared-dependencies/issues/718)) ([5f8156e](https://togithub.com/googleapis/java-shared-dependencies/commit/5f8156e55c6a07b018a8c5efafa68be781b4288b))
-   update google.common-protos.version to v2.9.0 ([#&#8203;714](https://togithub.com/googleapis/java-shared-dependencies/issues/714)) ([9e5591e](https://togithub.com/googleapis/java-shared-dependencies/commit/9e5591ec3035350450ecbfebd00e08216433b06c))
-   update google.core.version to v2.8.0 ([#&#8203;719](https://togithub.com/googleapis/java-shared-dependencies/issues/719)) ([4023c60](https://togithub.com/googleapis/java-shared-dependencies/commit/4023c6063a2c5b5308da531df1a08c90c491965d))
-   update iam.version to v1.4.0 ([#&#8203;700](https://togithub.com/googleapis/java-shared-dependencies/issues/700)) ([c1097a4](https://togithub.com/googleapis/java-shared-dependencies/commit/c1097a46ab0739b0b7234bc510e4c3d9ce2c2861))
-   update iam.version to v1.4.1 ([#&#8203;716](https://togithub.com/googleapis/java-shared-dependencies/issues/716)) ([e2dc7c2](https://togithub.com/googleapis/java-shared-dependencies/commit/e2dc7c21c39e007878841e2664d548ec44a72d54))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-functions).
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
@release-please
chore(main): release 2.4.1 (#431)
aa3eb1b 
🤖 I have created a release *beep* *boop*
---


## [2.4.1](googleapis/java-functions@v2.4.0...v2.4.1) (2022-06-23)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#430](googleapis/java-functions#430)) ([252174a](googleapis/java-functions@252174a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@renovate-bot
deps: update dependency com.google.apis:google-api-services-cloudreso…
a23acd8 
…urcemanager to v1-rev20210331-1.31.0 (googleapis#430)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| com.google.apis:google-api-services-cloudresourcemanager | `v1-rev20210309-1.31.0` -> `v1-rev20210331-1.31.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v1-rev20210331-1.31.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v1-rev20210331-1.31.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v1-rev20210331-1.31.0/compatibility-slim/v1-rev20210309-1.31.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.apis:google-api-services-cloudresourcemanager/v1-rev20210331-1.31.0/confidence-slim/v1-rev20210309-1.31.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@release-please
chore: release 0.119.1 (googleapis#431)
d189ab8 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.119.1](https://www.github.com/googleapis/java-resourcemanager/compare/v0.119.0...v0.119.1) (2021-04-12)


### Dependencies

* update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20210331-1.31.0 ([googleapis#430](https://www.github.com/googleapis/java-resourcemanager/issues/430)) ([a23acd8](https://www.github.com/googleapis/java-resourcemanager/commit/a23acd8d255f0075e78c856f19e239b20504cbe0))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.0 ([googleapis#429](https://www.github.com/googleapis/java-resourcemanager/issues/429)) ([138bde5](https://www.github.com/googleapis/java-resourcemanager/commit/138bde5836792ac727ced90d28bba1d26bc6ee51))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 2.1.9-SNAPSHOT (#430)
799105d 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@suztomo
ci: removing clirr from required checks (#430)
b7735d6 
Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 0.12.1 (#430)
148eee3 
🤖 I have created a release *beep* *boop*
---


## [0.12.1](googleapis/java-analytics-admin@v0.12.0...v0.12.1) (2022-07-13)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-analytics-admin/issues/1485)) ([#429](googleapis/java-analytics-admin#429)) ([dc33d4e](googleapis/java-analytics-admin@dc33d4e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
@gcf-owl-bot
chore(bazel): update protobuf to v3.21.7 (#430)
e72c431 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 477955264

Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9
github-actions bot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this pull request Nov 8, 2022
@gcf-owl-bot @chingor13
chore(java): add a note in README for migrated split repos (googleapi…
6b940a9 
…s#1687) (googleapis#430)

* chore(java): add a note in README for migrated split repos

Disable renovate bot and flaky bot for split repositories
that have moved to the Java monorepo.
The Java monorepo will pass the "monorepo=True" parameter
to java.common_templates method in its owlbot.py files so that
the migration note will not appear in the README in the monorepo.

Co-authored-by: Jeff Ching <[email protected]>
Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 1.6.1-SNAPSHOT (#430)
a982815 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core auth cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajkannan @aozarov @googlebot