Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3918 GCS NIO readAttributes returns CloudStorageObjectAttributes for directory like objects #4261

Closed
wants to merge 31 commits into from
Closed

3918 GCS NIO readAttributes returns CloudStorageObjectAttributes for directory like objects #4261

wants to merge 31 commits into from

Conversation

andrey-qlogic
Copy link

Fixes #3918 GCS NIO readAttributes returns CloudStorageObjectAttributes for directory like objects

@andrey-qlogic andrey-qlogic requested a review from a team as a code owner December 27, 2018 13:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2018
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 27, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 27, 2018
@andrey-qlogic andrey-qlogic changed the title 3918 3918 GCS NIO readAttributes returns CloudStorageObjectAttributes for directory like objects Dec 28, 2018
@sduskis sduskis added the api: storage Issues related to the Cloud Storage API. label Dec 28, 2018
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 28, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 28, 2018
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 28, 2018
@jean-philippe-martin
Copy link

Ah, I hadn't seen this when I wrote my own fix for this same issue, in #4267.

In my case I made sure that .isRegularFile and .isDirectory both return true because that reflects the reality of the situation. While your fix is simpler, I think isRegularFile would return false there.

We could either update yours or go with mine if you like it, either's fine.

@ajaaym ajaaym added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 31, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 31, 2018
javabrown and others added 10 commits December 31, 2018 12:35
@javabrown @sduskis
Spanner: closed watch-dog daemon threads spawned by Spanner client (g…
e9ea3d9 
…oogleapis#4263)

* Fixed Issue - shutting-down WatchDog daemon threads spawned by Spanner client

* Fixed Issue - shutdown watchDog daemon threads spawned by Spanner client

* Minor code formatting

* Fixed Kokoro code format issue
@chingor13
Fix Kokoro release jobs (googleapis#4225)
fb2b690 
* Fix Kokoro release jobs. Needs loopback pinentry-mode

* Skip install on deploy

* skip stagingProfileId

* Capture built artifacts

* Enable promote/drop jobs via environment variable

* Fix directory path and use -B for drop/release

* promote/drop need the settings file

* Fix path to settings file

* Update RELEASING documentation to use the Kokoro jobs
@charlesliqlogic @chingor13
Pub/Sub: Add message abandonment (googleapis#4250)
6e2c2dd 
* add abandonment

* add unit test for abandon

* update forget() to stop extending deadline
@chingor13
BigQuery: Fix Maximum Bytes Billed property. (googleapis#4262)
70d7efb 
* Fix Maximum Bytes Billed

* remove whitespace
@kenfesta @chingor13
Update UsePubSubEmulatorSnippet.java (googleapis#4256)
f526a44
@ajaaym @chingor13
Logging: disable severity based flush on write by default (googleapis…
63a9cb7 
…#4254)

* fix googleapis#3880 googleapis#2796 disable automatic flush on write to avoid hanging and leaking threads as grpc also uses this appender which goes in to deadlock over time.

* fix formatting

* add flush before listing
@chingor13
Docs: Fix maven site generation (googleapis#4232)
7978818 
The configuration for aggregate changed from an attribute to a report
@igorbernstein2
Bigtable: deprecate the use of typesafe names (googleapis#4257)
b7c1878 
* Bigtable: deprecate the use of typesafe names

Unfortunately typesafe names create more issues for bigtable than they solve. A lot of the time users need to use both bigtable data & admin apis. Unfortunately, those apis define the same names in different namespaces. This forces users to use fully qualified names which is ugly. Also, absolute names don't benefit the bigtable client because the client is anchored at the instance and all names end up being relative

* fix docs

* format code
@charlesliqlogic @chingor13
Fixed cannot call public methods in via reflection (googleapis#4249)
2b9f530 
* modified package-private to public

* update format for storage/Option.java
@chingor13
BigQuery : Fix numBytes, numRows in TableInfo/Table (googleapis#4271)
73e93c0 
* Fix NumBytes and NumRows

* update NumBytes and NumRows

* remove setter

* update methods and resolved test case
elisheva-qlogic and others added 15 commits January 3, 2019 15:06
@elisheva-qlogic @igorbernstein2
Cloud Bigtable: helloWorld sample (googleapis#4274)
eb6c4d2 
* helloWorld sample

* test class modified

* format change in ITHelloWorld
@chingor13
Add .tmpl extension for README.md so releasetool is not confused (goo…
b2a95a0 
…gleapis#4280)
@kolea2 @chingor13
Release v0.75.0 (googleapis#4282)
c367308
@kolea2 @chingor13
Bump next snapshot (googleapis#4286)
6d56b8c
@ajaaym
Fix googleapis#4284 NPE for getZone (googleapis#4289)
ca7054e
@yoshi-automation @sduskis
Regenerate securitycenter client (googleapis#4290)
ba4ba16
@igorbernstein2
Bigtable admin: deprecate typesafe names part 2 (googleapis#4258)
28720b5 
* Bigtable admin: deprecate typesafe names

This is a followup on googleapis#4257:
Unfortunately typesafe names create more issues for bigtable than they solve. A lot of the time users need to use both bigtable data & admin apis. Unfortunately, those apis define the same names in different namespaces. This forces users to use fully qualified names which is ugly. Also, absolute names don't benefit the bigtable client because the client is anchored at the instance and all names end up being relative

* format code

* fix year
@yoshi-automation @chingor13
Regenerate iamcredentials client (googleapis#4277)
978f3b7
@chingor13
Revert "Pub/Sub: Add message abandonment (googleapis#4250)" (googleap…
f28bbcc 
…is#4297)

This reverts commit 6e2c2dd.
@romlogic @sduskis
updated links (googleapis#4287)
d2302cd 
* updated links

* updated link

* added new line
@chingor13
Release v0.76.0 (googleapis#4298)
395b016
3918: Added checking of attributes size for 0
e4db5fd
3918: Added a unit test
3cbdcd7
3918: Fixed codestyle error
8fb687f
Merge branch '3918' of https://github.com/andrey-qlogic/google-cloud-…
d6ea4d5 
…java into 3918
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 8, 2019
@andrey-qlogic andrey-qlogic deleted the 3918 branch January 8, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.