Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gax javadoc link to point to latest. #4215

Closed
wants to merge 2 commits into from
Closed

Update gax javadoc link to point to latest. #4215

wants to merge 2 commits into from

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Dec 12, 2018

No description provided.

@kolea2 kolea2 requested a review from a team December 12, 2018 21:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2018
@chingor13 chingor13 self-assigned this Dec 12, 2018
@chingor13
Copy link
Contributor

Is this actually what we want to do? If this library depends on 1.35.0, shouldn't these links always point to the 1.35.0 docs instead of whatever the latest is?

@kolea2
Copy link
Contributor Author

kolea2 commented Dec 12, 2018

True, I was initially looking at this pull request (#2991) which references eventually switching gax.version to latest, but I see your point. Maybe we could look into having one variable for gax.version instead of updating it just for the javadoc. What do you think?

@chingor13
Copy link
Contributor

It may be difficult as we need to specify the gax version in the bom and google-cloud-clients and they do not currently share a parent (which would let us share properties).

If you can find a way to have us maintain the version in a single place, that would be fantastic.

@kolea2
Copy link
Contributor Author

kolea2 commented Dec 12, 2018

Gotcha - I'll look into it. In the meantime, it sounds like we won't be switching to the latest/ link so I'll go ahead and close out this PR.

@kolea2 kolea2 closed this Dec 12, 2018
@kolea2 kolea2 deleted the gax-javadoc-change branch December 12, 2018 22:25
@chingor13
Copy link
Contributor

Specifying the version in one place is not unique to gax. We should create a cleanup issue to do this across all of our dependencies where possible.

@kolea2
Copy link
Contributor Author

kolea2 commented Dec 13, 2018

Created issue #4223 for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chingor13 chingor13

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolea2 @chingor13 @googlebot