Bigtable Java samples #3946

elisheva-qlogic · 2018-11-15T15:28:57Z

HelloWorld, TableAdmin, and InstanceAdmin examples

igorbernstein2

This is a good start, I added some comments, but didn't do a full review. Can you help me understand how samples work? how/who uses the comment tags? What are snippets? Why are other products differentiate between examples and snippets?

google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+import com.google.cloud.bigtable.data.v2.models.RowMutation;
+import java.sql.Timestamp;
+
+// [START HelloWorld]


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+    String COLUMN_FAMILY_ID = "cf1";
+    String COLUMN_QUALIFIER = "greeting";
+    String INSTANCE_ID = System.getenv("INSTANCE_ID");
+    String GCLOUD_PROJECT_ID = System.getenv("GCLOUD_PROJECT_ID");


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+    String COLUMN_FAMILY_ID = "cf1";
+    String COLUMN_QUALIFIER = "greeting";
+    String INSTANCE_ID = System.getenv("INSTANCE_ID");
+    String GCLOUD_PROJECT_ID = System.getenv("GCLOUD_PROJECT_ID");


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+
+    try {
+      System.out.println("Write some greetings to the table");
+      String[] greetings = { "Hello World!", "Hello Bigtable!", "Hello Node!" };


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+      String[] greetings = { "Hello World!", "Hello Bigtable!", "Hello Node!" };
+      for (int i = 0; i < greetings.length; i++) {
+        RowMutation rowMutation = RowMutation.create(TABLE_ID, rowKeyPrefix + i);
+        long timestamp = new Timestamp(System.currentTimeMillis()).getTime();


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/InstanceAdmin.java

+            .println("PRODUCTION type instance : " + instance.getId() + " created successfully");
+
+      } catch (Exception e) {
+        System.out.println("Error creating prod-instance: " + e.getMessage());


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/InstanceAdmin.java

+    deleteCluster(adminClient, "ssd-instance", "ssd-cluster");
+
+    // end operations with deleting the pro-instance created in `runInstanceOperations`
+    deleteInstance(adminClient, "ssd-instance");


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/InstanceAdmin.java

+        BigtableInstanceAdminClient.create(instanceAdminSettings);
+
+    System.out.println("Create an instance (type: PRODUCTION) and run basic instance-operations");
+    runInstanceOperations(adminClient, "ssd-instance", "ssd-cluster");


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/InstanceAdmin.java

+    System.out.println("Delete the Instance");
+    deleteInstance(adminClient, "hdd-instance");
+
+    System.out.println("Add Cluster");


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/InstanceAdmin.java

+    try {
+      adminClient.deleteInstance(instanceID);
+      System.out.println("Instance deleted: " + instanceID);
+    } catch (Exception e) {


sduskis · 2018-11-15T16:26:30Z

@igorbernstein2, the snippets are used in https://cloud.google.com/bigtable/docs/. Our documentation has a tool to pull in code based on the tags

igorbernstein2 · 2018-11-15T16:44:38Z

Also, to @chingor13 comment, it would be good to add tests to make sure these snippets continue to work

sduskis · 2018-12-04T15:58:32Z

@elisheva-qlogic, there's a build failure:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project google-cloud-examples: Compilation failure
[ERROR] /tmpfs/src/github/google-cloud-java/google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/TableAdmin.java:[56,60] incompatible types
[ERROR]   required: java.util.List<com.google.bigtable.admin.v2.TableName>
[ERROR]   found:    java.util.List<java.lang.String>

igorbernstein2

I think this sample should be restructured a bit

google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+      String TABLE_ID,
+      String ROW_KEY_PREFIX,
+      String COLUMN_FAMILY_ID,
+      String COLUMN_QUALIFIER) {


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+        dataClient.mutateRow(rowMutation);
+        System.out.println(greetings[i]);
+      }
+    } catch (Exception e) {


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+        System.out.println(greetings[i]);
+      }
+    } catch (Exception e) {
+      System.out.println("Exception while writing to table: " + e.getMessage());


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+    } catch (Exception e) {
+      System.out.println("Exception while writing to table: " + e.getMessage());
+    }
+    return mutation;


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+    } catch (Exception e) {
+      System.out.println("Exception while reading table: " + e.getMessage());
+    }
+    return rowStream;


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+  }
+
+  public static Table createTable(
+      BigtableTableAdminClient adminClient, String TABLE_ID, String COLUMN_FAMILY_ID) {


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+
+public class HelloWorld {
+
+  public static void main(String... args) throws Exception {


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/TableAdmin.java

+
+    final String GCLOUD_PROJECT = args[0];
+    final String INSTANCE_ID = args[1];
+    final String TABLE_ID = "table";


google-cloud-examples/src/test/java/com/google/cloud/examples/bigtable/HelloWorldTest.java

+  private static final String ROW_KEY_PREFIX = "test-rowKey";
+  private static BigtableDataClient dataClient;
+  private static BigtableTableAdminClient adminClient;
+


elisheva-qlogic · 2018-12-24T18:50:53Z

The main change is that HelloWorld sample is restructured. If this looks good, I will work on restructuring TableAdmin and InstanceAdmin samples like this as well.

google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+  private static String instanceId;
+  private static String tableId;
+  private static BigtableDataClient dataClient;
+  private static BigtableTableAdminClient adminClient;


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+      deleteTable();
+      garbageCollect();
+    } catch (ApiException e) {
+      System.err.println("Exception while running HelloWorld: " + e.getMessage());


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+    // [END connecting_to_bigtable]
+  }
+
+  public void run() throws Exception {


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+    if (!adminClient.exists(tableId)) {
+      CreateTableRequest createTableRequest =
+          CreateTableRequest.of(tableId).addFamily(columnFamily);
+      System.out.println("Creating table: " + tableId);


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+  private static final String tablePrefix = "table";
+  private static final String columnFamily = "cf1";
+  private static final String columnQualifier = "greeting";
+  private static final String rowKeyPrefix = "rowKey";


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+        dataClient.mutateRow(rowMutation);
+        System.out.println(greetings[i]);
+      }
+    } catch (ApiException e) {


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+  public void readTable() {
+    // [START scanning_all_rows]
+    try {
+      System.out.println("\n================= Reading the entire table =================");


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+      adminClient.deleteTable(tableId);
+    }
+  }
+}


google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

+        System.out.println(greetings[i]);
+      }
+    } catch (NotFoundException e) {
+      System.err.println("Exception while writing to table: " + e.getMessage());


google-cloud-examples/src/test/java/com/google/cloud/examples/bigtable/ITHelloWorld.java

+    }
+    tableId = generateTableId();
+    helloWorld = new HelloWorld(instanceName.getProject(), instanceName.getInstance(), tableId);
+    if (!adminClient.exists(tableId)) {


google-cloud-examples/src/test/java/com/google/cloud/examples/bigtable/ITHelloWorld.java

+
+    // Read a single row
+    OutputStream outputStream = new ByteArrayOutputStream();
+    System.setOut(new PrintStream(outputStream));


sduskis · 2019-01-02T17:52:51Z

Closing this in favor of #4274

elisheva-qlogic requested a review from a team as a code owner November 15, 2018 15:28

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2018

igorbernstein2 reviewed Nov 15, 2018

View reviewed changes

sduskis changed the title ~~Java samples~~ Bigtable Java samples Nov 15, 2018

elisheva-qlogic force-pushed the samples branch from 4f20ff6 to 514b3ab Compare December 6, 2018 21:29

elisheva-qlogic added 7 commits December 19, 2018 09:21

Java samples

b24d42f

Samples and tests

7932079

samples fixes

13b5c1c

code format fix

a5231c3

HelloWorld changes

adcafd0

system property for tests set up

5cc4f15

code format changes

7ad20e5

elisheva-qlogic force-pushed the samples branch from 4f35dbf to 7ad20e5 Compare December 19, 2018 14:29

igorbernstein2 requested changes Dec 19, 2018

View reviewed changes

changes

e57bb89

igorbernstein2 requested changes Dec 24, 2018

View reviewed changes

elisheva-qlogic added 2 commits December 27, 2018 15:22

HelloWorld updates

b8b4f22

exceptions specified

99b5c63

igorbernstein2 reviewed Dec 28, 2018

View reviewed changes

google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java

System.out.println(greetings[i]);

}

} catch (NotFoundException e) {

System.err.println("Exception while writing to table: " + e.getMessage());

This comment was marked as spam.

Sign in to view

igorbernstein2 reviewed Dec 28, 2018

View reviewed changes

sduskis closed this Jan 2, 2019


		public class HelloWorld {

		public static void main(String... args) throws Exception {

Bigtable Java samples #3946

Bigtable Java samples #3946

Conversation

elisheva-qlogic commented Nov 15, 2018

igorbernstein2 left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sduskis commented Nov 15, 2018

igorbernstein2 commented Nov 15, 2018

sduskis commented Dec 4, 2018

igorbernstein2 left a comment • edited Loading

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

elisheva-qlogic commented Dec 24, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sduskis commented Jan 2, 2019

igorbernstein2 left a comment •

edited

Loading