Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes cleanup issues #3874

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fixes cleanup issues #3874

merged 2 commits into from
Oct 31, 2018

Conversation

pmakani
Copy link

@pmakani pmakani commented Oct 30, 2018

Fixes

#3707 test-jar in google-cloud-bom.

#3728 Don't bundle tests in jars.

@pmakani pmakani requested a review from a team as a code owner October 30, 2018 11:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@sduskis
Copy link
Contributor

sduskis commented Oct 31, 2018

@chingor13, do you have any issues with this? @elharo, does this look right to you?

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2018
@chingor13 chingor13 merged commit bff49f9 into googleapis:master Oct 31, 2018
@chingor13 chingor13 mentioned this pull request Nov 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmakani @sduskis @chingor13 @elharo @googlebot @kokoro-team