-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put new retry options in CloudStorageConfiguration #3869
Merged
chingor13
merged 11 commits into
googleapis:master
from
jean-philippe-martin:configurable_errors
Nov 27, 2018
Merged
Put new retry options in CloudStorageConfiguration #3869
chingor13
merged 11 commits into
googleapis:master
from
jean-philippe-martin:configurable_errors
Nov 27, 2018
Commits on Oct 30, 2018
-
Put new retry options in CloudStorageConfiguration
Add retriableHttpCodes and reopenableExceptions so the user can, if they choose, customize the conditions under which we retry an access or reopen a channel after an exception closed it. This can be handy if a cloud provider starts transiently throwing exceptions that would normally indicate a fatal condition, but which in practice will pass if retried. The backoff logic in retries / reopens in unmodified.
Configuration menu - View commit details
-
Copy full SHA for 0f2b337 - Browse repository at this point
Copy the full SHA 0f2b337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4736a3c - Browse repository at this point
Copy the full SHA 4736a3cView commit details -
retriable -> retryable (in NIO Cloud Storage code)
Also add a few basic tests to make sure the retryable options do what we expect.
Configuration menu - View commit details
-
Copy full SHA for ef37bb3 - Browse repository at this point
Copy the full SHA ef37bb3View commit details -
Update testListFilesInRootDirectory to match reality
In the built-in UNIX filesystem, the newDirectoryStream method will return absolute paths if given absolute paths as input, and relative paths if given relative paths as input. We're now seeing this too for the NIO Cloud Storage provider (this is a good thing), so I updated this test to reflect this new reality.
Configuration menu - View commit details
-
Copy full SHA for 1a03432 - Browse repository at this point
Copy the full SHA 1a03432View commit details -
Configuration menu - View commit details
-
Copy full SHA for eab4881 - Browse repository at this point
Copy the full SHA eab4881View commit details
Commits on Nov 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c309bad - Browse repository at this point
Copy the full SHA c309badView commit details -
Configuration menu - View commit details
-
Copy full SHA for 721483d - Browse repository at this point
Copy the full SHA 721483dView commit details
Commits on Nov 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8474dcb - Browse repository at this point
Copy the full SHA 8474dcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40d473c - Browse repository at this point
Copy the full SHA 40d473cView commit details
Commits on Nov 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0eb2adb - Browse repository at this point
Copy the full SHA 0eb2adbView commit details
Commits on Nov 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 68a8412 - Browse repository at this point
Copy the full SHA 68a8412View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.