-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Bucket lock #3574
Merged
+579
−22
Merged
[Storage] Bucket lock #3574
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2f291d3
Add support for defaultEventBasedHold
frankyn 23c27bc
Add support for Blob eventBasedHold
frankyn 65357aa
Add support for blob temporary holds
frankyn 339e38d
Add support for lockRetentionPolicy and RetentionPolicy
frankyn 7078d02
Remove Beta launch annotations for CMEK
frankyn 8f34efa
Merge branch 'master' into gcs-bucket-lock
frankyn 154fef1
Update FakeStorageRPC
frankyn 7a10958
codacy-bot review fix (final only)
frankyn 5190137
Update getRetentionPolicyIsLocked() -> retentionPolicyIsLocked() and …
frankyn ced985d
Merge branch 'master' into gcs-bucket-lock
frankyn 2943c42
Address comments
frankyn 3bd389c
Address comments
frankyn 0c298a1
Merge branch 'master' into gcs-bucket-lock
frankyn b124131
Address comments.
frankyn 50b0cf7
Small nits
frankyn db07b0c
Fix additional comments
frankyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.