-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial GAX submission - generated classes only #317
Initial GAX submission - generated classes only #317
Conversation
- Add CopyRequest.target(BlobId) to add target with no contentType checks - Change CopyRequest.target(BlobInfo) to CopyRequest.target(BlobInfo, BlobTargetOptions...) - Remove CopyRequest.targetOptions method, options are only set with a BlobInfo target - Add new CopyRequest.of methods - Update tests and example
…rget Update CopyRequest to check target content type
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
In the <parent>
<groupId>com.google.gcloud</groupId>
<artifactId>gcloud-java-pom</artifactId>
<version>0.0.7-SNAPSHOT</version>
</parent> with: <parent>
<groupId>com.google.gcloud</groupId>
<artifactId>gcloud-java-pom</artifactId>
<version>0.0.11-SNAPSHOT</version>
</parent>
<properties>
<site.installationModule>gcloud-java-gax</site.installationModule>
</properties> |
Updated. |
I am not sure why the CLA verification is red. @jgeewax any idea? Other than that looks good to me. BTW, I think this approach of generating and including in the code common gRPC based classes (com.google.type.XXX) such as LatLng.java is going to get us into trouble at some point (e.g. datastore v1beta3 also includes them) as we will have the same classes (possiblly even with different /cc @pcostell |
@wrwg, can you comment on the potential conflicts with common gRPC based classes, and what our longer term plan is for them? |
/cc @anthmgoogle |
I'm seeing 3/6 commits not related to this change. The branch this is on may need rebasing. |
@anthmgoogle , those commits are there because of rebasing. |
@aozarov, we are building the grpc/proto generated libraries from the core up to form a clean hierarchy. The google/googleapis repo will go away, and will be replaced by a new repo which contains just the core protos, plus for each language a matching repo which can build and publish the generated artifacts. For gcloud, we were suggesting to follow the same model. There will be a new repo gcloud-protos, and it would be submoduled by gcloud-java. The gcloud-java would reference an artifact for the java version of the generated files for the core platform, and can then build all the files you see in this PR (minus the ones in the core because they are packaged) from scratch. There is a proof-of-concept (from which we are generating this PR), perhaps we can arrange for a showing. |
Initial GAX submission - generated classes only
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2020-11-19 17:07:05,693 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-resourcemanager/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working directory clean 2020-11-19 17:07:06,613 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/af5e158e-2654-41c4-bf87-eceaa4d3a691/targets - [ ] To automatically regenerate this PR, check this box.
🤖 I have created a release *beep* *boop* --- ## [2.2.1](googleapis/java-workflow-executions@v2.2.0...v2.2.1) (2022-06-27) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#316](googleapis/java-workflow-executions#316)) ([adeaf97](googleapis/java-workflow-executions@adeaf97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…oogleapis#317) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [3.7.0](googleapis/java-channel@v3.6.1...v3.7.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#311](googleapis/java-channel#311)) ([879a347](googleapis/java-channel@879a347)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#317](googleapis/java-channel#317)) ([55bd32e](googleapis/java-channel@55bd32e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.3.5](https://togithub.com/googleapis/java-profiler/compare/v2.3.4...v2.3.5) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([d8ec5f9](https://togithub.com/googleapis/java-profiler/commit/d8ec5f994b351c91f1eb3a3810ef782f5d316a98)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…onfig to v1.3.2 (#317) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.3.0` -> `1.3.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.2/compatibility-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.3.2/confidence-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.3.2`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​132-httpsgithubcomgoogleapisjava-shared-configcomparev131v132-2022-03-28) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.3.1...v1.3.2) ### [`v1.3.1`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​131-httpsgithubcomgoogleapisjava-shared-configcomparev130v131-2022-03-25) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.3.0...v1.3.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
Also including updates from master.