Add support for selected fields to blob get and list #312

mziccard · 2015-11-02T13:08:17Z

This follows from #193. Main changes are:

Add AclField and BlobField classes to Storage
Add BlobGetOption class to Storage that supports the .fields option
Use BlobGetOption in Storage.get instead of BlobSourceOption
Add .fields option to BlobListOption
Update Blob.exists to use selected fields
Use BlobGetOption in BatchRequest.toGet instead of BlobSourceOption
Add unit and integration tests for selected fields

gcloud-java-storage/src/main/java/com/google/gcloud/storage/Storage.java

+      super(selector);
+    }
+
+    public static BlobField acl(AclField... aclFields) {


aozarov · 2015-11-03T04:33:18Z

Looks good!

I think, for simplicity, we should reconsider ACL specific fields (the same way we don't expose owner specific fields). I don't even know how patch would work in such case.

Also, if we do so, I wonder if we could just have an enum instead of the BlobField and EntityField classes.

Providing an option to select fields for buckets (and having a BucketGetOption) would be nice too (and if we go with it, I would also suggest to expose only the high-level fields such as acl, lifecycle, cors and not, e.g. cors/maxAgeSeconds).

mziccard · 2015-11-03T17:20:14Z

I addressed the comments. I removed AclField so that we only deal with first level fields and made BlobField an enum. I also added support for selected fields to bucket get and list.

gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java

@@ -168,6 +169,7 @@ public StorageObject create(StorageObject storageObject, final InputStream conte
          .setPrefix(PREFIX.getString(options))
          .setMaxResults(MAX_RESULTS.getLong(options))
          .setPageToken(PAGE_TOKEN.getString(options))
+          .setFields(FIELDS.getString(options))


aozarov · 2015-11-03T20:00:00Z

Nice, I like it much better.
Few nits and one potential bug regarding bucket get/listing.

mziccard · 2015-11-04T16:48:42Z

I fixed the comments, thanks for the careful review.

mziccard · 2015-11-04T20:01:55Z

I will need to rebase this to fix conflicts. Please let me know if you are reviewing this, otherwise I'll rebase it first.

- Add AclField and BlobField classes to Storage - Add BlobGetOption class to Storage that supports the .fields option - Use BlobGetOption in Storage.get instead of BlobSourceOption - Add .fields option to BlobListOption - Updated Blob.exists to use selected fields - Use BlobGetOption in BatchRequest.toGet instead of BlobSourceOption - Add unit and integration tests for selected fields

- Remove AclField and make BlobField an enum type - Add BucketField enum to Storage - Add BucketGetOption class and use if for storage.get(bucket) - Add BucketSourceOption class to Bucket - Updated and add tests

…/BlobField

… fields

aozarov · 2015-11-04T20:54:59Z

@mziccard go ahead and re-base and let me know when ready for re-review.

BTW, I did have a look at it and all look great. One suggestion is to use the BlobField.values() and BucketField.values() for selecting all fields in the IT test.

mziccard · 2015-11-04T22:13:24Z

@aozarov Rebased and updated according to your last comment.

Add support for selected fields to blob get and list

🤖 I have created a release *beep* *boop* --- ## [3.6.1](googleapis/java-channel@v3.6.0...v3.6.1) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#310](googleapis/java-channel#310)) ([6b9eee2](googleapis/java-channel@6b9eee2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2020-11-17 20:37:43,247 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-resourcemanager/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working directory clean 2020-11-17 20:37:44,123 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/1ddc9e55-ed66-4f22-ba1d-f175fab6153b/targets - [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore(bazel): update protobuf to v3.21.7 PiperOrigin-RevId: 477955264 Source-Link: googleapis/googleapis@a724450 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…usage to v2.3.7 (#312) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-service-usage](https://togithub.com/googleapis/java-service-usage) | `2.3.6` -> `2.3.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-usage/2.3.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-usage/2.3.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-usage/2.3.7/compatibility-slim/2.3.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-usage/2.3.7/confidence-slim/2.3.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-service-usage).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Nov 2, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2015

aozarov reviewed Nov 3, 2015
View reviewed changes

gcloud-java-storage/src/main/java/com/google/gcloud/storage/Storage.java

super(selector);

}

public static BlobField acl(AclField... aclFields) {

This comment was marked as spam.

Sign in to view

aozarov reviewed Nov 3, 2015
View reviewed changes

mziccard added 6 commits November 4, 2015 21:08

Add support for selected fields to bucket get and list

bea0157

- Remove AclField and make BlobField an enum type - Add BucketField enum to Storage - Add BucketGetOption class and use if for storage.get(bucket) - Add BucketSourceOption class to Bucket - Updated and add tests

Add field selection to StorageRpc bucket get and list

f11c05a

Add field selection to Bucket.exist

ba4bfa6

Delete EntityField class and remove non-accessible fields from Bucket…

46b60df

…/BlobField

Add IT tests for bucket's field selection, add test for selecting all…

603d50c

… fields

Use BlobField and BucketField .values() in IT tests

af7a08b

mziccard force-pushed the add-support-for-selected-fields branch from 91af2c1 to af7a08b Compare November 4, 2015 22:06

aozarov added a commit that referenced this pull request Nov 5, 2015

Merge pull request #312 from mziccard/add-support-for-selected-fields

fac7687

Add support for selected fields to blob get and list

aozarov merged commit fac7687 into googleapis:master Nov 5, 2015

mziccard mentioned this pull request Nov 30, 2015

Add support in Storage RPC level for request with selected fields. #193

Closed

github-actions bot pushed a commit that referenced this pull request Jul 1, 2022

chore: remove java7 units check from required checks in master (#312)

66a0b9e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for selected fields to blob get and list #312

Add support for selected fields to blob get and list #312

mziccard commented Nov 2, 2015

This comment was marked as spam.

aozarov commented Nov 3, 2015

mziccard commented Nov 3, 2015

This comment was marked as spam.

aozarov commented Nov 3, 2015

mziccard commented Nov 4, 2015

mziccard commented Nov 4, 2015

aozarov commented Nov 4, 2015

mziccard commented Nov 4, 2015

Add support for selected fields to blob get and list #312

Add support for selected fields to blob get and list #312

Conversation

mziccard commented Nov 2, 2015

This comment was marked as spam.

aozarov commented Nov 3, 2015

mziccard commented Nov 3, 2015

This comment was marked as spam.

aozarov commented Nov 3, 2015

mziccard commented Nov 4, 2015

mziccard commented Nov 4, 2015

aozarov commented Nov 4, 2015

mziccard commented Nov 4, 2015