Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for DocumentSnapshot cursors #2768

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Adding support for DocumentSnapshot cursors #2768

merged 2 commits into from
Jan 17, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
pongad
pongad reviewed Jan 15, 2018
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @garrettjonesgoogle PTAL

@garrettjonesgoogle
Copy link
Member

LGTM

@schmidt-sebastian schmidt-sebastian merged commit d3f16f3 into googleapis:master Jan 17, 2018
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jan 17, 2018
Closed
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jan 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pongad pongad pongad left review comments

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @garrettjonesgoogle @pongad @googlebot