-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RemoteGcsHelper unit tests #272
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3c71bf2
Add create from stream to RemoteGcsHelper, fix javadoc format
mziccard f24b2bf
Add RemoteGcsHelper unit tests
mziccard 1c5030a
Fix testForceDeleteTimeout and add test for fatal failure
mziccard 862ea6a
Removed RemoteGcsHeler.Option
mziccard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
156 changes: 156 additions & 0 deletions
156
gcloud-java-storage/src/test/java/com/google/gcloud/storage/RemoteGcsHelperTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,156 @@ | ||
/* | ||
* Copyright 2015 Google Inc. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.gcloud.storage; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertTrue; | ||
|
||
import com.google.common.collect.ImmutableList; | ||
import com.google.gcloud.storage.testing.RemoteGcsHelper; | ||
|
||
import java.io.ByteArrayInputStream; | ||
import java.io.InputStream; | ||
import java.nio.file.Files; | ||
import java.nio.file.Paths; | ||
import java.util.Iterator; | ||
import java.util.List; | ||
import java.util.UUID; | ||
import java.util.concurrent.ExecutionException; | ||
import java.util.concurrent.TimeUnit; | ||
|
||
import org.easymock.EasyMock; | ||
import org.junit.BeforeClass; | ||
import org.junit.Rule; | ||
import org.junit.Test; | ||
import org.junit.rules.ExpectedException; | ||
|
||
public class RemoteGcsHelperTest { | ||
|
||
private static final String BUCKET_NAME = "bucket-name"; | ||
private static final String PROJECT_ID = "project-id"; | ||
private static final String JSON_KEY = "{\n" | ||
+ " \"private_key_id\": \"somekeyid\",\n" | ||
+ " \"private_key\": \"-----BEGIN PRIVATE KEY-----\\nMIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggS" | ||
+ "kAgEAAoIBAQC+K2hSuFpAdrJI\\nnCgcDz2M7t7bjdlsadsasad+fvRSW6TjNQZ3p5LLQY1kSZRqBqylRkzteMOyHg" | ||
+ "aR\\n0Pmxh3ILCND5men43j3h4eDbrhQBuxfEMalkG92sL+PNQSETY2tnvXryOvmBRwa/\\nQP/9dJfIkIDJ9Fw9N4" | ||
+ "Bhhhp6mCcRpdQjV38H7JsyJ7lih/oNjECgYAt\\nknddadwkwewcVxHFhcZJO+XWf6ofLUXpRwiTZakGMn8EE1uVa2" | ||
+ "LgczOjwWHGi99MFjxSer5m9\\n1tCa3/KEGKiS/YL71JvjwX3mb+cewlkcmweBKZHM2JPTk0ZednFSpVZMtycjkbLa" | ||
+ "\\ndYOS8V85AgMBewECggEBAKksaldajfDZDV6nGqbFjMiizAKJolr/M3OQw16K6o3/\\n0S31xIe3sSlgW0+UbYlF" | ||
+ "4U8KifhManD1apVSC3csafaspP4RZUHFhtBywLO9pR5c\\nr6S5aLp+gPWFyIp1pfXbWGvc5VY/v9x7ya1VEa6rXvL" | ||
+ "sKupSeWAW4tMj3eo/64ge\\nsdaceaLYw52KeBYiT6+vpsnYrEkAHO1fF/LavbLLOFJmFTMxmsNaG0tuiJHgjshB\\" | ||
+ "n82DpMCbXG9YcCgI/DbzuIjsdj2JC1cascSP//3PmefWysucBQe7Jryb6NQtASmnv\\nCdDw/0jmZTEjpe4S1lxfHp" | ||
+ "lAhHFtdgYTvyYtaLZiVVkCgYEA8eVpof2rceecw/I6\\n5ng1q3Hl2usdWV/4mZMvR0fOemacLLfocX6IYxT1zA1FF" | ||
+ "JlbXSRsJMf/Qq39mOR2\\nSpW+hr4jCoHeRVYLgsbggtrevGmILAlNoqCMpGZ6vDmJpq6ECV9olliDvpPgWOP+\\nm" | ||
+ "YPDreFBGxWvQrADNbRt2dmGsrsCgYEAyUHqB2wvJHFqdmeBsaacewzV8x9WgmeX\\ngUIi9REwXlGDW0Mz50dxpxcK" | ||
+ "CAYn65+7TCnY5O/jmL0VRxU1J2mSWyWTo1C+17L0\\n3fUqjxL1pkefwecxwecvC+gFFYdJ4CQ/MHHXU81Lwl1iWdF" | ||
+ "Cd2UoGddYaOF+KNeM\\nHC7cmqra+JsCgYEAlUNywzq8nUg7282E+uICfCB0LfwejuymR93CtsFgb7cRd6ak\\nECR" | ||
+ "8FGfCpH8ruWJINllbQfcHVCX47ndLZwqv3oVFKh6pAS/vVI4dpOepP8++7y1u\\ncoOvtreXCX6XqfrWDtKIvv0vjl" | ||
+ "HBhhhp6mCcRpdQjV38H7JsyJ7lih/oNjECgYAt\\nkndj5uNl5SiuVxHFhcZJO+XWf6ofLUregtevZakGMn8EE1uVa" | ||
+ "2AY7eafmoU/nZPT\\n00YB0TBATdCbn/nBSuKDESkhSg9s2GEKQZG5hBmL5uCMfo09z3SfxZIhJdlerreP\\nJ7gSi" | ||
+ "dI12N+EZxYd4xIJh/HFDgp7RRO87f+WJkofMQKBgGTnClK1VMaCRbJZPriw\\nEfeFCoOX75MxKwXs6xgrw4W//AYG" | ||
+ "GUjDt83lD6AZP6tws7gJ2IwY/qP7+lyhjEqN\\nHtfPZRGFkGZsdaksdlaksd323423d+15/UvrlRSFPNj1tWQmNKk" | ||
+ "XyRDW4IG1Oa2p\\nrALStNBx5Y9t0/LQnFI4w3aG\\n-----END PRIVATE KEY-----\\n\",\n" | ||
+ " \"client_email\": \"[email protected]\",\n" | ||
+ " \"client_id\": \"someclientid.apps.googleusercontent.com\",\n" | ||
+ " \"type\": \"service_account\"\n" | ||
+ "}"; | ||
private static final InputStream JSON_KEY_STREAM = new ByteArrayInputStream(JSON_KEY.getBytes()); | ||
private static final List<BlobInfo> BLOB_LIST = ImmutableList.of( | ||
BlobInfo.builder(BUCKET_NAME, "n1").build(), | ||
BlobInfo.builder(BUCKET_NAME, "n2").build()); | ||
private static final ListResult<BlobInfo> BLOB_LIST_RESULT = new ListResult<BlobInfo>() { | ||
|
||
@Override | ||
public String nextPageCursor() { | ||
return "listResult"; | ||
} | ||
|
||
@Override | ||
public ListResult<BlobInfo> nextPage() { | ||
return null; | ||
} | ||
|
||
@Override | ||
public Iterator<BlobInfo> iterator() { | ||
return BLOB_LIST.iterator(); | ||
} | ||
}; | ||
private static String KEY_PATH = "/does/not/exist/key." + UUID.randomUUID().toString() + ".json"; | ||
|
||
@Rule | ||
public ExpectedException thrown = ExpectedException.none(); | ||
|
||
@BeforeClass | ||
public static void beforeClass() { | ||
while (Files.exists(Paths.get(JSON_KEY))) { | ||
KEY_PATH = "/does/not/exist/key." + UUID.randomUUID().toString() + ".json"; | ||
} | ||
} | ||
|
||
@Test | ||
public void testForceDelete() throws InterruptedException, ExecutionException { | ||
Storage storageMock = EasyMock.createMock(Storage.class); | ||
EasyMock.expect(storageMock.list(BUCKET_NAME)).andReturn(BLOB_LIST_RESULT); | ||
for (BlobInfo info : BLOB_LIST) { | ||
EasyMock.expect(storageMock.delete(BUCKET_NAME, info.name())).andReturn(true); | ||
} | ||
EasyMock.expect(storageMock.delete(BUCKET_NAME)).andReturn(true); | ||
EasyMock.replay(storageMock); | ||
assertTrue(RemoteGcsHelper.forceDelete(storageMock, BUCKET_NAME, 5, TimeUnit.SECONDS)); | ||
EasyMock.verify(storageMock); | ||
} | ||
|
||
@Test | ||
public void testForceDeleteTimeout() throws InterruptedException, ExecutionException { | ||
Storage storageMock = EasyMock.createMock(Storage.class); | ||
EasyMock.expect(storageMock.list(BUCKET_NAME)).andReturn(BLOB_LIST_RESULT); | ||
for (BlobInfo info : BLOB_LIST) { | ||
EasyMock.expect(storageMock.delete(BUCKET_NAME, info.name())).andReturn(true); | ||
} | ||
EasyMock.expect(storageMock.delete(BUCKET_NAME)).andReturn(false); | ||
EasyMock.replay(storageMock); | ||
assertTrue(!RemoteGcsHelper.forceDelete(storageMock, BUCKET_NAME, 50, TimeUnit.MICROSECONDS)); | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
} | ||
|
||
@Test | ||
public void testCreateFromStream() { | ||
RemoteGcsHelper helper = RemoteGcsHelper.create(PROJECT_ID, JSON_KEY_STREAM); | ||
StorageOptions options = helper.options(); | ||
assertEquals(PROJECT_ID, options.projectId()); | ||
assertEquals(60000, options.connectTimeout()); | ||
assertEquals(60000, options.readTimeout()); | ||
assertEquals(10, options.retryParams().getRetryMaxAttempts()); | ||
assertEquals(6, options.retryParams().getRetryMinAttempts()); | ||
assertEquals(30000, options.retryParams().getMaxRetryDelayMillis()); | ||
assertEquals(120000, options.retryParams().getTotalRetryPeriodMillis()); | ||
assertEquals(250, options.retryParams().getInitialRetryDelayMillis()); | ||
} | ||
|
||
@Test | ||
public void testCreateNoKey() { | ||
thrown.expect(RemoteGcsHelper.GcsHelperException.class); | ||
thrown.expectMessage(KEY_PATH + " (No such file or directory)"); | ||
RemoteGcsHelper.create(PROJECT_ID, KEY_PATH); | ||
} | ||
|
||
@Test | ||
public void testCreateNoKeyWithOption() { | ||
thrown.expect(RemoteGcsHelper.GcsHelperException.class); | ||
thrown.expectMessage(KEY_PATH + " not found in classpath"); | ||
RemoteGcsHelper.create(PROJECT_ID, KEY_PATH, RemoteGcsHelper.Option.keyFromClassPath()); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.