BREAKING pubsub: fix and simplify deadline extension #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies deadline extension and fixes at least one known issue: modack storm. In the previous implementation, setting padding time too high can cause us to schedule deadline extension into the past. We have observed cases where 4 modacks were sent per message immediately upon receipt. With this change, such problems should be impossible. The breaking change: this commit removes the user's ability to set padding. Instead, we set it at 5 seconds, the same with current Go implementation. As described earlier, padding is subtle and difficult to use/implement correctly. We can add it back later, so plumbing code was not entirely removed. Either way, this should not block stabilization. Other major changes: - Deadline adjustment is removed to simplify deadline extension. This can also be added back later. Currently the stream deadline is set to 60s. - Deadline extension runs on schedule and modacks all pending messages regardless of when they expire. This is clearly suboptimal, but does not greatly matter right now, since it runs only once a minute. This commit also introduces MessageDispatcherTest. It should be simpler and flakes less than SubscriberTest, since we can tightly control the timing. SubscriberTest should eventually go away, replaced by both MessageDispatcherTest and integration tests.
googlebot
added
the
cla: yes
|
SubscriberTest is flakey, but looks like MessageDispatcherTest isn't :) |
|
cc @mdietz94 |
| List<PendingModifyAckDeadline> ackDeadlineExtensions) { | ||
| List<PendingModifyAckDeadline> modifyAckDeadlinesToSend = | ||
| Lists.newArrayList(ackDeadlineExtensions); | ||
| @VisibleForTesting |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good as an emergency fix to prevent mod ack storm |
mdietz94
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies deadline extension
and fixes at least one known issue: modack storm.
In the previous implementation, setting padding time too high
can cause us to schedule deadline extension into the past.
We have observed cases where 4 modacks were sent per message
immediately upon receipt.
With this change, such problems should be impossible.
The breaking change: this commit removes the user's ability
to set padding. Instead, we set it at 5 seconds, the same
with current Go implementation.
As described earlier, padding is subtle and
difficult to use/implement correctly.
We can add it back later,
so plumbing code was not entirely removed.
Either way, this should not block stabilization.
Other major changes:
This can also be added back later.
Currently the stream deadline is set to 60s.
messages regardless of when they expire.
This is clearly suboptimal, but does not greatly matter right now,
since it runs only once a minute.
This commit also introduces MessageDispatcherTest.
It should be simpler and flakes less than SubscriberTest,
since we can tightly control the timing.
SubscriberTest should eventually go away,
replaced by both MessageDispatcherTest and integration tests.