Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage use of API key in translation #2147

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Discourage use of API key in translation #2147

merged 1 commit into from
Jun 23, 2017

Conversation

tcoffee-google
Copy link
Contributor

Addresses #1594.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 81.162% when pulling 42afcd1 on tcoffee-google:translate_api_key into 7c20c6f on GoogleCloudPlatform:master.

@tcoffee-google
Copy link
Contributor Author

@gguuss PTAL

gguuss
gguuss approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gguuss
Copy link
Contributor

gguuss commented Jun 22, 2017

Code looked good but Travis test is failing. Once it passes the change should resolve the issue.

@tcoffee-google
Copy link
Contributor Author

Travis is currently hitting a build time limit on OS X.

@tcoffee-google tcoffee-google merged commit a898acc into googleapis:master Jun 23, 2017
@tcoffee-google tcoffee-google deleted the translate_api_key branch June 23, 2017 00:34
@tcoffee-google tcoffee-google mentioned this pull request Jun 23, 2017
Closed
tcoffee-google added a commit to tcoffee-google/google-cloud-java that referenced this pull request Jun 30, 2017
@tcoffee-google
Make Translate auth documentation clear and consistent
b89d7d1 
Additional updates prompted by googleapis#1594 / googleapis#2147.
@tcoffee-google tcoffee-google mentioned this pull request Jun 30, 2017
Merged
tcoffee-google added a commit that referenced this pull request Jul 14, 2017
@tcoffee-google
Make Translate auth documentation clear and consistent (#2208)
8e074f3 
* Make Translate auth documentation clear and consistent

Additional updates prompted by #1594 / #2147.

* Fix doc link

* Fix Spanner doc example

* Work around Javadoc bug

https://bugs.openjdk.java.net/browse/JDK-8130754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcoffee-google @coveralls @gguuss @googlebot