Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logback logging appender : class loader fix for custom enhancers #2130

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Logback logging appender : class loader fix for custom enhancers #2130

merged 1 commit into from
Jun 8, 2017

Conversation

jabubake
Copy link
Contributor

@jabubake jabubake commented Jun 8, 2017

@jabubake jabubake added the api: logging Issues related to the Cloud Logging API. label Jun 8, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c1cb85f on jabubake:patch-logging-logback into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle
Copy link
Member

Could you give an explanation of this fix?

@jabubake
Copy link
Contributor Author

jabubake commented Jun 8, 2017

The use of ClassLoader.getSystemClassLoader() restricts the visibility to the classpath.
Frameworks (like Play) use dynamic class loaders. Hence delegating to logback's Loader.
Reference : http://www.javaworld.com/article/2077344/core-java/find-a-way-out-of-the-classloader-maze.html

@garrettjonesgoogle
Copy link
Member

LGTM

@jabubake jabubake merged commit d43a540 into googleapis:master Jun 8, 2017
@jabubake jabubake deleted the patch-logging-logback branch June 8, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jabubake @coveralls @garrettjonesgoogle @googlebot