Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing timeout settings that are set but never used #1934

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Removing timeout settings that are set but never used #1934

merged 1 commit into from
Apr 18, 2017

Conversation

garrettjonesgoogle
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 80.933% when pulling 730394c on garrettjonesgoogle:alt into b6a87b0 on GoogleCloudPlatform:master.

@michaelbausor
Copy link
Contributor

LGTM - did these used to be used? Or have they never been used at all?

@garrettjonesgoogle
Copy link
Member Author

Yes, they used to be used, but @vam-google 's PR #1738 stopped using them after RetrySettings was introduced. Now, going through RetrySettings (which can be set on ServiceOptions) is the correct thing to do.

@garrettjonesgoogle garrettjonesgoogle merged commit 455f739 into googleapis:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google Awaiting requested review from vam-google

@michaelbausor michaelbausor Awaiting requested review from michaelbausor

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garrettjonesgoogle @coveralls @michaelbausor @googlebot