Add tests for BlobWriteChannel and BlobReadChannel #188

mziccard · 2015-09-29T10:30:04Z

This PR goes in the direction of testing gcloud-java-storage as pointed out in #14. Tests for BlobWriterChannelImpl and BlobReadChannelImpl are added.
I decided to split these testing contributions into more PRs so that they are easier to review and merge.

As part of this PR I also suggest we either rename BlobWriterChannelImpl to BlobWriteChannelImpl or BlobReadChannelImpl to BlobReaderChannelImpl for consistency (I would go with BlobWriterChannelImpl -> BlobWriteChannelImpl).

…elImpl

aozarov · 2015-09-29T18:34:12Z

+1 for BlobWriteChannelImpl (I am pretty sure it was a typo).

gcloud-java-storage/src/test/java/com/google/gcloud/storage/BlobReadChannelTest.java

+import java.util.Map;
+import java.util.Random;
+
+public class BlobReadChannelTest {


Add tests for BlobWriteChannel and BlobReadChannel

…oogleapis#188) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | major | `6.0.0` -> `7.0.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-resourcemanager).

…-settings to v1.2.1 (googleapis#188) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-resource-settings](https://togithub.com/googleapis/java-resource-settings) | `1.2.0` -> `1.2.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-resource-settings/1.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-resource-settings/1.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-resource-settings/1.2.1/compatibility-slim/1.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-resource-settings/1.2.1/confidence-slim/1.2.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-resource-settings</summary> ### [`v1.2.1`](https://togithub.com/googleapis/java-resource-settings/blob/HEAD/CHANGELOG.md#121-httpsgithubcomgoogleapisjava-resource-settingscomparev120v121-2022-06-23) [Compare Source](https://togithub.com/googleapis/java-resource-settings/compare/v1.2.0...v1.2.1) ##### Dependencies - update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#&googleapis#8203;183](https://togithub.com/googleapis/java-resource-settings/issues/183)) ([eb6829a](https://togithub.com/googleapis/java-resource-settings/commit/eb6829a9d7be69eb88629bd1fa8f621163762e40)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resource-settings).

) * chore: update dependencies for regapic * add more dependencies and trigger comment * update goldens * fix indentation * remove duplicate gax-httpjson dependency * remove duplicated dependencies Source-Link: googleapis/synthtool@fa54eb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906

…oogleapis#188) * feat: Add Provider resources PiperOrigin-RevId: 449653329 Source-Link: googleapis/googleapis@a167db1 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4183d84217dec636dfc8acac8d991379ffe84c73 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDE4M2Q4NDIxN2RlYzYzNmRmYzhhY2FjOGQ5OTEzNzlmZmU4NGM3MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore(deps): upgrade gapic-generator-java to 2.8.0 and update gax-java to 2.18.1 PiperOrigin-RevId: 450543911 Source-Link: googleapis/googleapis@5528344 Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Integrate new gapic-generator-java and rules_gapic PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update pom.xml * fix: update gapic-generator-java with mock service generation fixes PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu Shaji <[email protected]>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/ca0c8ac8-6f14-468f-80f2-67e8a2c09f54/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 357800868 Source-Link: googleapis/googleapis@e8bc447

🤖 I have created a release *beep* *boop* --- ## [0.4.1](googleapis/java-gke-connect-gateway@v0.4.0...v0.4.1) (2022-07-01) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#183](googleapis/java-gke-connect-gateway#183)) ([3c58d98](googleapis/java-gke-connect-gateway@3c58d98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [1.3.2](googleapis/java-eventarc@v1.3.1...v1.3.2) (2022-07-01) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([#188](googleapis/java-eventarc#188)) ([8abfe61](googleapis/java-eventarc@8abfe61)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…onfig to v1.5.1 (#188) * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.1.1](googleapis/java-datastream@v1.1.0...v1.1.1) (2022-07-19) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-datastream/issues/1485)) ([#187](googleapis/java-datastream#187)) ([1c2f621](googleapis/java-datastream@1c2f621)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. feat: add DeleteTransferJob operation feat: add AWS S3 compatible data source PiperOrigin-RevId: 473348271 Source-Link: googleapis/googleapis@56f2049 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4f0ba4ff11c129006f76be68465f8e68a4a32814 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGYwYmE0ZmYxMWMxMjkwMDZmNzZiZTY4NDY1ZjhlNjhhNGEzMjgxNCJ9

🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/java-storage-transfer@v1.2.2...v1.3.0) (2022-09-15) ### Features * add AWS S3 compatible data source ([da2afe2](googleapis/java-storage-transfer@da2afe2)) * Add default retry configuration ([#188](googleapis/java-storage-transfer#188)) ([da2afe2](googleapis/java-storage-transfer@da2afe2)) * add DeleteTransferJob operation ([da2afe2](googleapis/java-storage-transfer@da2afe2)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#190](googleapis/java-storage-transfer#190)) ([724ef94](googleapis/java-storage-transfer@724ef94)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [markupsafe](https://palletsprojects.com/p/markupsafe/) ([changelog](https://markupsafe.palletsprojects.com/changes/)) | `==2.0.1` -> `==2.1.1` | [![age](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/compatibility-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/confidence-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam-admin).

Add test for blob channels, remove duplicated call in BlobWriterChann…

575fa1f

…elImpl

mziccard added api: storage Issues related to the Cloud Storage API. testing labels Sep 29, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2015

aozarov reviewed Sep 29, 2015
View reviewed changes

gcloud-java-storage/src/test/java/com/google/gcloud/storage/BlobReadChannelTest.java

import java.util.Map;

import java.util.Random;

public class BlobReadChannelTest {

This comment was marked as spam.

Sign in to view

mziccard added 2 commits September 29, 2015 22:36

Remove redundant read test, add buffered write test, add EasyMock.verify

967c429

Renaming BlobWriterChannelImpl to BlobWriteChannelImpl, renaming tests

7145030

aozarov added a commit that referenced this pull request Sep 30, 2015

Merge pull request #188 from mziccard/test-storage-blob-channels

5d8d123

Add tests for BlobWriteChannel and BlobReadChannel

aozarov merged commit 5d8d123 into googleapis:master Sep 30, 2015

github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022

ci: removing clirr from required checks (googleapis#188)

479e803

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

chore: add native image checks as required (#188)

74060f4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for BlobWriteChannel and BlobReadChannel #188

Add tests for BlobWriteChannel and BlobReadChannel #188

mziccard commented Sep 29, 2015

aozarov commented Sep 29, 2015

This comment was marked as spam.

Add tests for BlobWriteChannel and BlobReadChannel #188

Add tests for BlobWriteChannel and BlobReadChannel #188

Conversation

mziccard commented Sep 29, 2015

aozarov commented Sep 29, 2015

This comment was marked as spam.