logging: remove handler's buffer #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoggingHandler's buffer is redundant, since it's already using the batching feature. LoggingHandler.flush previously just flushes its own buffer and put messages in the batcher's buffer, without necessarily making RPC calls. This PR does not fix this problem, but it makes flush obviously wrong instead of subtly. The test for flush size is also removed. Flush size should be forwareded to the batcher, which already has its own test. Updates #1795.
googlebot
added
the
cla: yes
| buffer = new LinkedList<>(); | ||
| } | ||
| if (entry != null) { | ||
| write(entry, writeOptions); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggingHandler's buffer is redundant,
since it's already using the batching feature.
LoggingHandler.flush previously just flushes its own buffer
and put messages in the batcher's buffer,
without necessarily making RPC calls.
This PR does not fix this problem,
but it makes flush obviously wrong instead of subtly.
The test for flush size is also removed.
Flush size should be forwareded to the batcher,
which already has its own test.
Updates #1795.