pubsub: fix potential deadlock in startConnections #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a subscriber connection fails, awaitRunning will throw IllegalStateException. We must make sure that we count down the latch in either case; otherwise startup will deadlock. Also move the call to addListener above startAsync. Otherwise, the listener might not see the connection failing if it fails too quickly.
googlebot
added
the
cla: yes
|
Makes sense to me - @davidtorres can you take a look? |
rybosome
pushed a commit
to rybosome/google-cloud-java
that referenced
this pull request
Mar 9, 2017
If a subscriber connection fails, awaitRunning will throw IllegalStateException. We must make sure that we count down the latch in either case; otherwise startup will deadlock. Also move the call to addListener above startAsync. Otherwise, the listener might not see the connection failing if it fails too quickly.
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
…500) Revert "chore(deps): update dependency protobuf to v3.20.2 (#1659)" This reverts commit b59cf7b5a91ecab29e21fdfbb7e3b81066229be4. Source-Link: https://togithub.com/googleapis/synthtool/commit/a66e34625d760ad299627f6613a1bd438c1b62a9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd316b9a591c45264775ecaba72e37d65905925c323b68e51a08c4126e4b6d0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a subscriber connection fails, awaitRunning will throw
IllegalStateException.
We must make sure that we count down the latch in either case;
otherwise startup will deadlock.
Also move the call to addListener above startAsync.
Otherwise, the listener might not see the connection failing
if it fails too quickly.
cc @davidtorres @mdietz94