add test for Publisher and Subscriber snippets #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Changes Unknown when pulling d84ae75 on pongad:snippet-test into ** on GoogleCloudPlatform:master**. |
lesv
approved these changes
Feb 24, 2017
|
Of course, you need to fix what ever is making Travis unhappy. |
lesv
reviewed
Feb 24, 2017
| @Override | ||
| public void run() { | ||
| try { | ||
| received.set(queue.poll(10, TimeUnit.MINUTES)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@lesv The Travis failure seems to be coming from Spanner and unrelated to this change. Nearest I can tell, it might be from temporary connection issue while downloading Maven packages. I reran to make sure. |
|
LGTM from me, ping to @garrettjonesgoogle and @jabubake |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test code isn't as clear as I hoped, but I'm not sure how to simplify it without complicating the samples.
FYI @jabubake