Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race in FakeSubscriberServiceImpl #1592

Merged
merged 1 commit into from
Feb 7, 2017
Merged

fix race in FakeSubscriberServiceImpl #1592

merged 1 commit into from
Feb 7, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Feb 6, 2017

This is the same race as
#1495
but in sendStreamResponse rather than sendError.

@pongad
fix race in FakeSubscriberServiceImpl
4fd6705 
This is the same race as
#1495
but in sendStreamResponse rather than sendError.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.085% when pulling 4fd6705 on pongad:fix-race into 36e609e on GoogleCloudPlatform:pubsub-hp.

@garrettjonesgoogle
Copy link
Member

LGTM

@pongad pongad merged commit 709d21d into googleapis:pubsub-hp Feb 7, 2017
@pongad pongad deleted the fix-race branch February 7, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pongad @coveralls @garrettjonesgoogle @googlebot