Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuke LocalDnsHelper #1446

Merged
merged 1 commit into from
Dec 6, 2016
Merged

nuke LocalDnsHelper #1446

merged 1 commit into from
Dec 6, 2016

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Dec 5, 2016

The emulator is a frequent source of test failures and not used anywhere
useful.

@pongad
nuke LocalDnsHelper
7efcda6 
The emulator is a frequent source of test failures and not used anywhere
useful.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
@garrettjonesgoogle
Copy link
Member

sayonara (i.e. LGTM after Travis tests pass)

@pongad
Copy link
Contributor Author

pongad commented Dec 5, 2016

Update #1429

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 83.512% when pulling 7efcda6 on pongad:nuke-dns-helper into 0d9d1b3 on GoogleCloudPlatform:master.

@pongad pongad merged commit b24ec1a into googleapis:master Dec 6, 2016
@pongad pongad deleted the nuke-dns-helper branch December 6, 2016 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pongad @garrettjonesgoogle @coveralls @googlebot