Support using more recent datastore emulator versions via gcloud emulators #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @lesv |
googlebot
added
the
cla: yes
|
LGTM - if only folks always kept versions like you expect them. It's likely the emulator will keep the correct scheme, but lots of teams use 0.1.2-1.9.42, 0.2.3-beta, 0.2.3-SNAPSHOT, or 0.2.3-rev172 etc. |
|
@lesv I was strict on the version format on purpose. I prefer the helper to download its own release version of the emulator rather than possibly using a beta/alpha version already installed via |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1300 for good