Use Futures.transform instead of lazyTransform when possible #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mziccard
added
api: pubsub
googlebot
added
the
cla: yes
|
Awesome, thanks so much @mziccard ! I built a 0.2.8-SNAPSHOT from your branch and ran it in one of our applications that calls thanks again! |
|
/cc @lesv |
|
LGTM - I'm presuming some integration tests will run to verify this for logging. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
Source-Link: googleapis/synthtool@1a2878d Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:12cbdc4f137152a1a8b83f50ebc1a4098be0d3baff78b46efaec306f7cfafd13 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
Source-Link: googleapis/synthtool@1a2878d Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:12cbdc4f137152a1a8b83f50ebc1a4098be0d3baff78b46efaec306f7cfafd13 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-automl@v2.2.4...v2.3.0) (2022-06-30) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#1168](googleapis/java-automl#1168)) ([2fd0096](googleapis/java-automl@2fd0096)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#1174](googleapis/java-automl#1174)) ([e5fb07e](googleapis/java-automl@e5fb07e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1148
@mattnworb this should make you happy :) Any change you can give it a try?