feat: [memorystore] new module for memorystore #11356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-java-bot
added
the
owlbot:run
…/google-cloud-java into new-library/memorystore-0Jhea
Comment on lines
+1439
to
+1443
| product_documentation: https://cloud.google.com/memorystore/docs/valkey | ||
| api_description: Memorystore for Valkey is a fully managed Valkey Cluster service | ||
| for Google Cloud. | ||
| client_documentation: | ||
| https://cloud.google.com/java/docs/reference/google-cloud-memorystore/latest/overview |
There was a problem hiding this comment.
Product documentation is specific to valkey, but client documentation is generic.
Are we going to have collision issues with any of these other Memorystore variants? https://cloud.google.com/memorystore/docs/
(Redis, Redis Cluster, Memcached)
There was a problem hiding this comment.
The client doc is unique if the artifact is unique, google-cloud-memorystore, in this case.
If you think memorystore is too generic, how about we change the artifact id to google-cloud-valkey? Redis, Redis Cluster, Memcached are all followed this pattern.
There was a problem hiding this comment.
Yes - following the existing pattern would be great -- thank you.
burkedavison
approved these changes
Dec 16, 2024
…/google-cloud-java into new-library/memorystore-0Jhea
…/google-cloud-java into new-library/memorystore-0Jhea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by @JoeWang1127 via generate_new_client_hermetic_build.yaml
Command used:
b/376713169
b/376713261