Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update renovate to only update libraries-bom version in README.md in 4 modules #10768

Merged
merged 3 commits into from
May 1, 2024
Merged

chore: update renovate to only update libraries-bom version in README.md in 4 modules #10768

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb72ebd
chore: update renovate to exclude libraries-bom update in README.md
JoeWang1127 Apr 30, 2024
772a307
Revert "chore: update renovate to exclude libraries-bom update in REA…
JoeWang1127 Apr 30, 2024
c0cdd24
only update libraries-bom in 4 modules
JoeWang1127 Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to remove this section all together, we still need it for vertex-ai, dns, notification and grafeas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the config to only update libraries bom version in these 4 modules.

PR title and description are also modified.

"fileMatch": [
"README.md"
"java-dns/README.md",
"java-grafeas/README.md",
"java-notification/README.md",
"java-vertexai/README.md"
],
"matchStrings": [
"<artifactId>libraries-bom</artifactId>\\s+<version>(?<currentValue>.*?)</version>"
Expand Down
Loading