Handle files over 2GB #1065
Merged
Handle files over 2GB #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -467,10 +467,13 @@ public RpcBatch createBatch() { | |||
| .setIfMetagenerationNotMatch(IF_METAGENERATION_NOT_MATCH.getLong(options)) | |||
| .setIfGenerationMatch(IF_GENERATION_MATCH.getLong(options)) | |||
| .setIfGenerationNotMatch(IF_GENERATION_NOT_MATCH.getLong(options)); | |||
| if (position<0) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Nice catch, see one minor comment. I wonder whether we should merge this fix into master so that we don't have to wait for the bigger |
|
Tests are green. Are we OK to merge this pull request? |
|
Thank you! |
mziccard
pushed a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 29, 2016
* Handle files over 2GB * Use Guava's checkArgument
mziccard
pushed a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 30, 2016
* Handle files over 2GB * Use Guava's checkArgument
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
#1065) * chore: copy functionality from io.grpc.internal.SharedResourceHolder Included related classes and test file. Tests were adapted to use an easymock mock * fix: remove grpc-core from deps * fix: add used undeclared dependency jsr305 * fix: add copy explanation comments, remove `@ThreadSafe` and related dependency * Update google-cloud-core-grpc/src/main/java/com/google/cloud/grpc/LogExceptionRunnable.java Co-authored-by: Mike Eltsufin <[email protected]> * Update google-cloud-core-grpc/src/main/java/com/google/cloud/grpc/SharedResourceHolder.java Co-authored-by: Mike Eltsufin <[email protected]> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Mike Eltsufin <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParallelCountBytes fails for files over 2GB. It turns out that's because the position is stored internally as an int instead of a long in gcloud-java-storage. This CL fixes this. Once we merge into master, it'll solve the same problem for master.
cc: @jart