Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v1beta2 of secretmanager #10577

Merged
merged 7 commits into from
Mar 21, 2024
Merged

feat: add v1beta2 of secretmanager #10577

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0416bfb
feat: add `v1beta2` of `secretmanager`
diegomarquezp Mar 19, 2024
88e54bd
add generated `v1beta2` files
diegomarquezp Mar 20, 2024
bafa409
add grpc-common-protos
diegomarquezp Mar 20, 2024
95407d1
remove deep-preserve for v1beta1
diegomarquezp Mar 20, 2024
d61155f
correct preservation of ITs
diegomarquezp Mar 20, 2024
755c646
remove v1beta1 manually
diegomarquezp Mar 20, 2024
034e2a9
remove v1beta1 manually ii
diegomarquezp Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions generation_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,6 +1537,7 @@ libraries:
requires_billing: false
GAPICs:
- proto_path: google/cloud/secretmanager/v1
- proto_path: google/cloud/secretmanager/v1beta2

- api_shortname: securesourcemanager
name_pretty: Secure Source Manager API
Expand Down
8 changes: 4 additions & 4 deletions java-secretmanager/.OwlBot.yaml
View file
Open in desktop
Copy link
Contributor Author

@diegomarquezp diegomarquezp Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be handled by @JoeWang1127 's upcoming scripts, for now, can you manually run the generation script and add the changes as part of this PR?

@blakeli0 the generation went well after a small tweak to the owlbot yaml. This is something we need to add to the release notes.

Edit: added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another point in favor of normalizing the owlbot yaml regexes

Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ deep-preserve-regex:


deep-copy-regex:
- source: "/google/cloud/secretmanager/(v\\d)/.*-java/proto-google-.*/src"
- source: "/google/cloud/secretmanager/(v\\d.*)/.*-java/proto-google-.*/src"
dest: "/owl-bot-staging/java-secretmanager/$1/proto-google-cloud-secretmanager-$1/src"
- source: "/google/cloud/secretmanager/(v\\d)/.*-java/grpc-google-.*/src"
- source: "/google/cloud/secretmanager/(v\\d.*)/.*-java/grpc-google-.*/src"
dest: "/owl-bot-staging/java-secretmanager/$1/grpc-google-cloud-secretmanager-$1/src"
- source: "/google/cloud/secretmanager/(v\\d)/.*-java/gapic-google-.*/src"
- source: "/google/cloud/secretmanager/(v\\d.*)/.*-java/gapic-google-.*/src"
dest: "/owl-bot-staging/java-secretmanager/$1/google-cloud-secretmanager/src"
- source: "/google/cloud/secretmanager/(v\\d)/.*-java/samples/snippets/generated"
- source: "/google/cloud/secretmanager/(v\\d.*)/.*-java/samples/snippets/generated"
dest: "/owl-bot-staging/java-secretmanager/$1/samples/snippets/generated"

api-name: secretmanager
10 changes: 10 additions & 0 deletions java-secretmanager/google-cloud-secretmanager-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@
<artifactId>grpc-google-cloud-secretmanager-v1beta1</artifactId>
<version>2.38.0-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-secretmanager-v1beta1:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-secretmanager-v1beta2</artifactId>
<version>2.38.0-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-secretmanager-v1beta2:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-secretmanager-v1</artifactId>
Expand All @@ -45,6 +50,11 @@
<artifactId>proto-google-cloud-secretmanager-v1beta1</artifactId>
<version>2.38.0-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-secretmanager-v1beta1:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-secretmanager-v1beta2</artifactId>
<version>2.38.0-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-secretmanager-v1beta2:current} -->
</dependency>
</dependencies>
</dependencyManagement>
</project>
9 changes: 9 additions & 0 deletions java-secretmanager/google-cloud-secretmanager/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-common-protos</artifactId>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-secretmanager-v1beta2</artifactId>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v1</artifactId>
Expand Down Expand Up @@ -89,6 +93,11 @@
<artifactId>grpc-google-cloud-secretmanager-v1</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-secretmanager-v1beta2</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-secretmanager-v1beta1</artifactId>
Expand Down
2,945 changes: 2,945 additions & 0 deletions ...ager/src/main/java/com/google/cloud/secretmanager/v1beta2/SecretManagerServiceClient.java
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading