Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split_release_note.py to use repo-metadata.json too #10303

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 30, 2024

Fixes #10297

When split_release_note.py was searching for changelog files, it was looking for only OwlBot.yaml files. The java-vertexai module has a special setup where it does not need OwlBot.yaml files. With this PR, the script also looks for repo-metadata file (which java-vertexai module has).

TODO: After this is merged, confirm the Release Please pull request #10284 gets the fixed commit for java-vertexai's CHANGELOG file.

@suztomo suztomo requested a review from a team as a code owner January 30, 2024 15:42
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expect the actual CHANGELOG.md for java-vertexai to appear as part of some other process?

@suztomo suztomo enabled auto-merge (squash) January 30, 2024 16:15
@suztomo suztomo merged commit e87ef32 into main Jan 30, 2024
30 checks passed
@suztomo suztomo deleted the i10297 branch January 30, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHANGELOG.md is not generated for java-vertexai module
2 participants