Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: [aiplatform] Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData #10221

Merged
merged 8 commits into from
Jan 19, 2024
Merged

fix!: [aiplatform] Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData #10221

merged 8 commits into from
Jan 19, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 12, 2024 •
edited
Loading

  • Regenerate this pull request now.

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
feat: add CountTokens method to llm_utility_service
docs: minor changes to comments

PiperOrigin-RevId: 597667108

Source-Link: googleapis/googleapis@714ab03

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3ff71b39d2ad2eeb5113940c5de5593da0527b26
Copy-Tag: eyJwIjoiamF2YS1haXBsYXRmb3JtLy5Pd2xCb3QueWFtbCIsImgiOiIzZmY3MWIzOWQyYWQyZWViNTExMzk0MGM1ZGU1NTkzZGEwNTI3YjI2In0=

BEGIN_NESTED_COMMIT
fix!: [aiplatform] Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData
feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
docs: minor changes to comments

PiperOrigin-RevId: 597666793

Source-Link: googleapis/googleapis@84ee19c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8dc3e3e32043acd6893bed96a6b4566f00843329
Copy-Tag: eyJwIjoiamF2YS1haXBsYXRmb3JtLy5Pd2xCb3QueWFtbCIsImgiOiI4ZGMzZTNlMzIwNDNhY2Q2ODkzYmVkOTZhNmI0NTY2ZjAwODQzMzI5In0=
END_NESTED_COMMIT

@gcf-owl-bot
fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTe…
d5d0f99 
…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
docs: minor changes to comments

PiperOrigin-RevId: 597666793

Source-Link: googleapis/googleapis@84ee19c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8dc3e3e32043acd6893bed96a6b4566f00843329
Copy-Tag: eyJwIjoiamF2YS1haXBsYXRmb3JtLy5Pd2xCb3QueWFtbCIsImgiOiI4ZGMzZTNlMzIwNDNhY2Q2ODkzYmVkOTZhNmI0NTY2ZjAwODQzMzI5In0=
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 12, 2024 01:12
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 12, 2024 01:12
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@gcf-owl-bot
fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTe…
10481c8 
…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
feat: add CountTokens method to llm_utility_service
docs: minor changes to comments

PiperOrigin-RevId: 597667108

Source-Link: googleapis/googleapis@714ab03

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3ff71b39d2ad2eeb5113940c5de5593da0527b26
Copy-Tag: eyJwIjoiamF2YS1haXBsYXRmb3JtLy5Pd2xCb3QueWFtbCIsImgiOiIzZmY3MWIzOWQyYWQyZWViNTExMzk0MGM1ZGU1NTkzZGEwNTI3YjI2In0=
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jan 12, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 3019 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@lqiu96
Copy link
Contributor

lqiu96 commented Jan 19, 2024

Failing header check:

java-aiplatform/samples/snippets/generated/com/google/cloud/aiplatform/v1beta1/llmutilityservice/counttokens/AsyncCountTokens.java should have a copyright year of 2024
java-aiplatform/samples/snippets/generated/com/google/cloud/aiplatform/v1beta1/llmutilityservice/counttokens/SyncCountTokens.java should have a copyright year of 2024
java-aiplatform/samples/snippets/generated/com/google/cloud/aiplatform/v1beta1/llmutilityservice/counttokens/SyncCountTokensEndpointnameListvalue.java should have a copyright year of 2024
java-aiplatform/samples/snippets/generated/com/google/cloud/aiplatform/v1beta1/llmutilityservice/counttokens/SyncCountTokensStringListvalue.java should have a copyright year of 2024

I believe this is fine. Header check should be resolved in a future PR.

@lqiu96 lqiu96 merged commit 90a9033 into main Jan 19, 2024
32 of 33 checks passed
@lqiu96 lqiu96 deleted the owl-bot-copy-java-aiplatform branch January 19, 2024 15:37
@release-please release-please bot mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @yoshi-kokoro