Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use layer 2 docker images and inherit sdk-platform-java-config as the parent #10184

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Jan 2, 2024

No description provided.

@mpeddada1 mpeddada1 requested a review from a team as a code owner January 2, 2024 17:25
@burkedavison
Copy link
Member

LGTM. Will approve once passing CI checks.

@mpeddada1 mpeddada1 closed this Jan 5, 2024
@mpeddada1 mpeddada1 reopened this Jan 5, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2024
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Jan 5, 2024

Running into Unable to read gs://cloud_devrel_public_logs/resultstore/.../build.log. Either the file does not exist or there is a permission issue. for all three Kokoro checks except Kokoro - Test: Samples

@mpeddada1
Copy link
Contributor Author

Turned out to be a UI issue.

@mpeddada1 mpeddada1 requested a review from burkedavison January 8, 2024 16:22
@mpeddada1
Copy link
Contributor Author

gax: 2.39.0 which is brought in by shared-dependencies 3.21.0 is being included as expected:

15:52:17:029 [WARNING] Properties file at 'jar:file:///root/.m2/repository/com/google/auth/google-auth-library-oauth2-http/1.21.0/google-auth-library-oauth2-http-1.21.0.jar!/META-INF/native-image/native-image.properties' does not match the recommended 'META-INF/native-image/com.google.auth/google-auth-library-oauth2-http/native-image.properties' layout.
15:52:17:039 [INFO] Executing: /opt/graalvm-ce-java11-22.3.3/bin/native-image -cp /tmpfs/src/github/google-cloud-java/java-compute/google-cloud-compute/target/classes:/tmpfs/src/github/google-cloud-java/java-compute/google-cloud-compute/target/test-classes:/root/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/root/.m2/repository/com/google/api/grpc/proto-google-iam-v1/1.25.0/proto-google-iam-v1-1.25.0.jar:/root/.m2/repository/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar:/root/.m2/repository/com/google/api/api-common/2.22.0/api-common-2.22.0.jar:/root/.m2/repository/com/google/http-client/google-http-client/1.43.3/google-http-client-1.43.3.jar:/root/.m2/repository/com/google/api/gax/2.39.0/gax-2.39.0.jar:/root/.m2/repository/com/google/http-client/google-http-client-gson/1.43.3/google-http-client-gson-1.43.3.jar:/root/.m2/repository/org/junit/platform/junit-platform-commons/1.9.3/junit-platform-commons-1.9.3.jar:/root/.m2/repository/com/google/protobuf/protobuf-java-util/3.25.1/protobuf-java-util-3.25.1.jar:/root/.m2/repository/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.jar:/root/.m2/repository/com/google/api/gax/2.39.0/gax-2.39.0-

@mpeddada1 mpeddada1 merged commit c009e10 into main Jan 8, 2024
33 checks passed
@mpeddada1 mpeddada1 deleted the use-layer2-artifacts branch January 8, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants