-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubSub.listSubscriptions(topic) returns only names, not full subscriptions #978
Comments
/cc @eschapira Any reason for only returning the subscription names when one wants to get the list of subscriptions for a given topic? |
The topic owner/viewer may not have access to the subscription details; but they can see the name of the subscriptions and delete those subscriptions. If we are using Subscription objects, as long as you don't need to fetch the details in order to instantiate it, meaning that you can instantiate a subscription object by just using the name, it should be fine to return the subscription object. It is important to keep in mind that these subscriptions may belong to a different project. |
This was taken care of in #984 |
🤖 I have created a release *beep* *boop* --- ## [4.8.0](googleapis/java-dialogflow@v4.7.5...v4.8.0) (2022-08-05) ### Features * deprecated the filter field and add resource_definition ([d58232f](googleapis/java-dialogflow@d58232f)) * provide new parameter cx_current_page, the unique identifier of the CX page to override the `current_page` in the session. Add filter field to ListAnswerRecordsRequest. And add AudioInput to analysis requests ([d58232f](googleapis/java-dialogflow@d58232f)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#979](googleapis/java-dialogflow#979)) ([aee2eab](googleapis/java-dialogflow@aee2eab)) ### Documentation * add more meaningful comments ([d58232f](googleapis/java-dialogflow@d58232f)) * add more meaningful comments ([d58232f](googleapis/java-dialogflow@d58232f)) * added an explicit note that DetectIntentRequest's text input is limited by 256 characters ([d58232f](googleapis/java-dialogflow@d58232f)) * **owlbot-java:** explaining why not using formatter in pom.xml ([#1511](https://github.com/googleapis/java-dialogflow/issues/1511)) ([#973](googleapis/java-dialogflow#973)) ([3202efe](googleapis/java-dialogflow@3202efe)), closes [#1502](https://github.com/googleapis/java-dialogflow/issues/1502) * updated some method comments and added an explicit note that DetectIntentRequest's text input is limited by 256 characters ([#954](googleapis/java-dialogflow#954)) ([d58232f](googleapis/java-dialogflow@d58232f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…1.1 (#978) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE4NC4yIn0=-->
…telligence-bom to v2.2.5 (#978) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-video-intelligence-bom](https://togithub.com/googleapis/java-video-intelligence) | `2.2.4` -> `2.2.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.5/compatibility-slim/2.2.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence-bom/2.2.5/confidence-slim/2.2.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4zIn0=-->
🤖 I have created a release *beep* *boop* --- ## [3.7.0](googleapis/java-dlp@v3.6.7...v3.7.0) (2022-09-15) ### Features * Add Deidentify action ([#977](googleapis/java-dlp#977)) ([4f43cd5](googleapis/java-dlp@4f43cd5)) ### Bug Fixes * Update DeIdentificationTest ([#976](googleapis/java-dlp#976)) ([661f316](googleapis/java-dlp@661f316)) ### Dependencies * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#960](googleapis/java-dlp#960)) ([c66384d](googleapis/java-dlp@c66384d)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#969](googleapis/java-dlp#969)) ([586795f](googleapis/java-dlp@586795f)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#974](googleapis/java-dlp#974)) ([b37407b](googleapis/java-dlp@b37407b)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#982](googleapis/java-dlp#982)) ([8ac525a](googleapis/java-dlp@8ac525a)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#980](googleapis/java-dlp#980)) ([885dc15](googleapis/java-dlp@885dc15)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#984](googleapis/java-dlp#984)) ([8cd0a40](googleapis/java-dlp@8cd0a40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.49.2` -> `1.50.0` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.50.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.50.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.50.0/compatibility-slim/1.49.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.50.0/confidence-slim/1.49.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.50.0`](https://togithub.com/grpc/grpc-java/releases/tag/v1.50.0) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.49.2...v1.50.0) #### New Features - okhttp: Added connection management features to okhttp server, including maxConnectionIdle(), permitKeepAliveTime(), and permitKeepAliveWithoutCalls() ([#​9494](https://togithub.com/grpc/grpc-java/issues/9494), [#​9544](https://togithub.com/grpc/grpc-java/issues/9544)) - binder: Add `SecurityPolicies` for checking device owner/profile owner ([#​9428](https://togithub.com/grpc/grpc-java/issues/9428)) #### API Changes - api: Add LoadBalancer.acceptResolvedAddresses() ([#​9498](https://togithub.com/grpc/grpc-java/issues/9498)). The method is like `handleResolvedAddresses()` but returns a `boolean` of whether the addresses and configuration were accepted. Not accepting the update triggers the NameResolver to retry after a delay. We are not yet encouraging migration to this method, as there is still a second future API change - core: add CallOptions to CallCredentials.RequestInfo ([#​9538](https://togithub.com/grpc/grpc-java/issues/9538)) #### Bug Fixes - auth: Fix AppEngine failing while retrieving access token when instantiating a blocking stub using AppEngineCredentials ([#​9504](https://togithub.com/grpc/grpc-java/issues/9504)) - core: Ensure that context cancellationCause is set ([#​9501](https://togithub.com/grpc/grpc-java/issues/9501)) - core: Update outlier detection max ejection logic to allow exceeding the limit by one, to match Envoy. ([#​9489](https://togithub.com/grpc/grpc-java/issues/9489), [#​9492](https://togithub.com/grpc/grpc-java/issues/9492)) - core: outlier detection to honor min host request volume ([#​9490](https://togithub.com/grpc/grpc-java/issues/9490)) - okhttp: Add timeout for HTTP CONNECT proxy handshake ([#​9586](https://togithub.com/grpc/grpc-java/issues/9586)) - xds: ringhash policy in TRANSIENT_FAILURE should not attempt connecting when already in connecting ([#​9535](https://togithub.com/grpc/grpc-java/issues/9535)). With workloads where most requests have the same hash, ring hash should behave more like pick-first of slowly trying backends #### Dependencies - netty: upgrade netty from 4.1.77.Final to 4.1.79.Final and tcnative from 2.0.53 to 2.0.54 ([#​9451](https://togithub.com/grpc/grpc-java/issues/9451)) #### Acknowledgements [@​cpovirk](https://togithub.com/cpovirk) [@​prateek-0](https://togithub.com/prateek-0) [@​sai-sunder-s](https://togithub.com/sai-sunder-s) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzIuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzOC40In0=-->
We need to change the signature of:
Page<Subscription> listSubscriptions(String topic, ListOption... options)
Future<AsyncPage<Subscription>> listSubscriptionsAsync(String topic, ListOption... options);
to:
Page<String> listSubscriptions(String topic, ListOption... options)
Future<AsyncPage<String>> listSubscriptionsAsync(String topic, ListOption... options);
As listing subscriptions by topic returns only names (see here). /cc @aozarov
The text was updated successfully, but these errors were encountered: