Added batch support to the local DNS helper. #925

mderka · 2016-04-14T21:09:06Z

No description provided.

coveralls · 2016-04-14T21:18:01Z

Changes Unknown when pulling b783fe8 on mderka:bhelper into * on GoogleCloudPlatform:dns-alpha-batch*.

coveralls · 2016-04-14T23:53:23Z

Changes Unknown when pulling 3eebaa8 on mderka:bhelper into * on GoogleCloudPlatform:dns-alpha-batch*.

gcloud-java-dns/src/main/java/com/google/cloud/dns/testing/LocalDnsHelper.java

-      URI relative = BASE_CONTEXT.relativize(exchange.getRequestURI());
+      URI relative = null;
+      try {
+        relative = BASE_CONTEXT.relativize(new URI(exchange.getRequestURI().getRawPath()));


ajkannan · 2016-04-15T01:44:52Z

LocalDnsHelperTest.java:2916:86: error: ',' is not followed by whitespace.

Edit: Fixed.

coveralls · 2016-04-15T02:02:50Z

Changes Unknown when pulling 0b168fb on mderka:bhelper into * on GoogleCloudPlatform:dns-alpha-batch*.

ajkannan · 2016-04-15T02:15:42Z

On lines 1951-2 in the tests, why do we assertEquals(first, results.get(1)); and assertEquals(second, results.get(0));?

Edit: The order of zones to be returned is not specified. Switched to using contains.

ajkannan · 2016-04-15T02:20:06Z

Missing "batch.submit()" in testCombined()

EDIT: Done.

ajkannan · 2016-04-15T02:25:41Z

Done with my pass.

gcloud-java-dns/src/main/java/com/google/cloud/dns/testing/LocalDnsHelper.java

@@ -112,6 +119,15 @@
  private static final ScheduledExecutorService EXECUTORS =
      Executors.newScheduledThreadPool(2, Executors.defaultThreadFactory());
  private static final String PROJECT_ID = "dummyprojectid";
+  private static final String responseBoundary = "____THIS_IS_HELPERS_BOUNDARY____";


aozarov · 2016-04-15T06:20:19Z

Finished with my pass on the main code. Didn't complete a thorough review of the tests, though they seem fine (I think code could be more compact if you created 2 inner class for RpcBatch.Callback<T>one of which fails on success and other fails on exception and used them accordingly).

Contains minor test adjustments.

coveralls · 2016-04-15T14:40:00Z

Changes Unknown when pulling e8aa3db on mderka:bhelper into * on GoogleCloudPlatform:dns-alpha-batch*.

mderka · 2016-04-15T15:00:22Z

I made the test code more compact by adding the nested implementations of callbacks. Ready to proceed.

coveralls · 2016-04-15T15:05:27Z

Changes Unknown when pulling 5931b30 on mderka:bhelper into * on GoogleCloudPlatform:dns-alpha-batch*.

Added batch support to the local DNS helper

🤖 I have created a release *beep* *boop* --- ## [2.1.4](googleapis/java-vision@v2.1.3...v2.1.4) (2022-06-27) ### Dependencies * update spring.version to v2.7.1 ([googleapis#925](googleapis/java-vision#925)) ([e52efbd](googleapis/java-vision@e52efbd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.0 (#925) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-speech).

…#925) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.9` -> `2.8.10` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/compatibility-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/confidence-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.10`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#2810-httpsgithubcomgoogleapisjava-corecomparev289v2810-2022-08-24) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.9...v2.8.10) ##### Dependencies - update dependency com.google.api:gax-bom to v2.19.0 ([#907](https://togithub.com/googleapis/java-core/issues/907)) ([51b824c](https://togithub.com/googleapis/java-core/commit/51b824c225fd7095138e1ec2b6d47af4e2a34352)) - update dependency io.grpc:grpc-bom to v1.49.0 ([#908](https://togithub.com/googleapis/java-core/issues/908)) ([fbccd2d](https://togithub.com/googleapis/java-core/commit/fbccd2daceb0984c7cb95f84f89a116e54bf4ddc)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-errorreporting).

🤖 I have created a release *beep* *boop* --- ## [0.124.4](googleapis/java-errorreporting@v0.124.3...v0.124.4) (2022-08-25) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#925](googleapis/java-errorreporting#925)) ([a05d20b](googleapis/java-errorreporting@a05d20b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.1 (#925) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-containeranalysis).

…1575) (#925) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [importlib-metadata](https://togithub.com/python/importlib_metadata) | `==4.8.3` -> `==4.12.0` | [![age](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/compatibility-slim/4.8.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/confidence-slim/4.8.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-language).

🤖 I have created a release *beep* *boop* --- ## [3.0.12](https://togithub.com/googleapis/java-recaptchaenterprise/compare/v3.0.11...v3.0.12) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([6b5278d](https://togithub.com/googleapis/java-recaptchaenterprise/commit/6b5278d54f47be0816a7918102b003f0df024f8c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* cleanup: Remove migrated files * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.8.15](googleapis/java-core@v2.8.14...v2.8.15) (2022-09-23) ### Dependencies * Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.0 ([#925](googleapis/java-core#925)) ([88a8523](googleapis/java-core@88a8523)) * Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.1 ([#926](googleapis/java-core#926)) ([9f348aa](googleapis/java-core@9f348aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Added batch support to the local DNS helper.

b783fe8

mderka added the api: dns Issues related to the Cloud DNS API. label Apr 14, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2016

Added one more combined test.

3eebaa8

ajkannan reviewed Apr 15, 2016
View reviewed changes

Refactored boundary variables to be static attributes.

0b168fb

aozarov reviewed Apr 15, 2016
View reviewed changes

Switched to reading byte stream using scanner.

e8aa3db

Contains minor test adjustments.

Added nested callback implementations in the test.

5931b30

aozarov merged commit e63bc53 into googleapis:dns-alpha-batch Apr 15, 2016

mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Apr 19, 2016

Added batch support to the local DNS helper. (googleapis#925)

6df1bb8

Added batch support to the local DNS helper

mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Apr 19, 2016

Added batch support to the local DNS helper. (googleapis#925)

b75652e

Added batch support to the local DNS helper

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

chore: add native image checks as required (#925)

dad41b3

This was referenced Aug 25, 2022

chore: release monorepo_script_output #8199

Closed

chore: release main #8222

Closed

release-please bot mentioned this pull request Oct 3, 2022

chore(new-main): release 0.1.0 #8510

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added batch support to the local DNS helper. #925

Added batch support to the local DNS helper. #925

mderka commented Apr 14, 2016

coveralls commented Apr 14, 2016

coveralls commented Apr 14, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Apr 15, 2016 •

edited by mderka

Loading

coveralls commented Apr 15, 2016

ajkannan commented Apr 15, 2016 •

edited by mderka

Loading

ajkannan commented Apr 15, 2016 •

edited by mderka

Loading

ajkannan commented Apr 15, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 15, 2016

coveralls commented Apr 15, 2016

mderka commented Apr 15, 2016

coveralls commented Apr 15, 2016

Added batch support to the local DNS helper. #925

Added batch support to the local DNS helper. #925

Conversation

mderka commented Apr 14, 2016

coveralls commented Apr 14, 2016

coveralls commented Apr 14, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Apr 15, 2016 • edited by mderka Loading

coveralls commented Apr 15, 2016

ajkannan commented Apr 15, 2016 • edited by mderka Loading

ajkannan commented Apr 15, 2016 • edited by mderka Loading

ajkannan commented Apr 15, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 15, 2016

coveralls commented Apr 15, 2016

mderka commented Apr 15, 2016

coveralls commented Apr 15, 2016

ajkannan commented Apr 15, 2016 •

edited by mderka

Loading

ajkannan commented Apr 15, 2016 •

edited by mderka

Loading

ajkannan commented Apr 15, 2016 •

edited by mderka

Loading