-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BasePageFetcher #485
Labels
Comments
github-actions bot
pushed a commit
that referenced
this issue
Jun 21, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this issue
Jun 29, 2022
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-05-13 14:02:12,557 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-resourcemanager/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-05-13 14:02:13,807 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/4e332dc1-8225-409d-9e7a-fe55b7657f76/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)
github-actions bot
pushed a commit
that referenced
this issue
Jul 14, 2022
…485) * chore(deps): update dependency com.google.cloud:libraries-bom to v26 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this issue
Aug 16, 2022
…s to v2.3.2 (#485) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-workflows](https://togithub.com/googleapis/java-workflows) | `2.3.1` -> `2.3.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-workflows/2.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-workflows/2.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-workflows/2.3.2/compatibility-slim/2.3.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-workflows/2.3.2/confidence-slim/2.3.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTQuOSIsInVwZGF0ZWRJblZlciI6IjMyLjE1NC45In0=-->
github-actions bot
pushed a commit
that referenced
this issue
Sep 30, 2022
…admin to v0.13.3 (#485) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.analytics:google-analytics-admin](https://togithub.com/googleapis/java-analytics-admin) | `0.13.2` -> `0.13.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.3/compatibility-slim/0.13.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.3/confidence-slim/0.13.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-analytics-admin). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
github-actions bot
pushed a commit
that referenced
this issue
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [2.5.3](https://togithub.com/googleapis/java-functions/compare/v2.5.2...v2.5.3) (2022-10-03) ### Dependencies * Update dependency certifi to v2022.9.24 ([#472](https://togithub.com/googleapis/java-functions/issues/472)) ([7b30732](https://togithub.com/googleapis/java-functions/commit/7b30732c6359a827616aed1dba184544df95ec37)) * Update dependency charset-normalizer to v2.1.1 ([#479](https://togithub.com/googleapis/java-functions/issues/479)) ([059a126](https://togithub.com/googleapis/java-functions/commit/059a1268254468b2b86950ad7d0ca8b4d4446d60)) * Update dependency click to v8.1.3 ([#480](https://togithub.com/googleapis/java-functions/issues/480)) ([808075d](https://togithub.com/googleapis/java-functions/commit/808075d9b02a6aa3bc7ad5ec94d6dc9b94cc2588)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#497](https://togithub.com/googleapis/java-functions/issues/497)) ([f8ac08b](https://togithub.com/googleapis/java-functions/commit/f8ac08b604a81f544a55e82f45cb540f6cf44638)) * Update dependency gcp-releasetool to v1.8.8 ([#477](https://togithub.com/googleapis/java-functions/issues/477)) ([5bbe57f](https://togithub.com/googleapis/java-functions/commit/5bbe57f388219a8d0e058a4199e9f5abf457e3a2)) * Update dependency google-api-core to v2.10.1 ([#481](https://togithub.com/googleapis/java-functions/issues/481)) ([05b981c](https://togithub.com/googleapis/java-functions/commit/05b981c68f17497993059c3cc082c8b854c82dc8)) * Update dependency google-cloud-core to v2.3.2 ([#473](https://togithub.com/googleapis/java-functions/issues/473)) ([70370a5](https://togithub.com/googleapis/java-functions/commit/70370a5883ee497d5934e9c874653fab6e692468)) * Update dependency importlib-metadata to v4.12.0 ([#482](https://togithub.com/googleapis/java-functions/issues/482)) ([bab4cb5](https://togithub.com/googleapis/java-functions/commit/bab4cb59880f91c8dd93e3ff07ac6152844744f2)) * Update dependency jeepney to v0.8.0 ([#483](https://togithub.com/googleapis/java-functions/issues/483)) ([ddb1529](https://togithub.com/googleapis/java-functions/commit/ddb1529c5f631703e047634b9c09e516c6ce16e8)) * Update dependency keyring to v23.9.3 ([#485](https://togithub.com/googleapis/java-functions/issues/485)) ([856993e](https://togithub.com/googleapis/java-functions/commit/856993e803c18331bed2e9c2576f4182694380b3)) * Update dependency markupsafe to v2.1.1 ([#486](https://togithub.com/googleapis/java-functions/issues/486)) ([bb11c09](https://togithub.com/googleapis/java-functions/commit/bb11c09a578191ea6b770b0b055474101f8462bb)) * Update dependency protobuf to v3.20.2 ([#487](https://togithub.com/googleapis/java-functions/issues/487)) ([875c9c2](https://togithub.com/googleapis/java-functions/commit/875c9c2a3e77010a0ba6052a23454c40a1349c4f)) * Update dependency typing-extensions to v4.3.0 ([#490](https://togithub.com/googleapis/java-functions/issues/490)) ([4b2af03](https://togithub.com/googleapis/java-functions/commit/4b2af03c457600c4e840e0a355d71200088b6096)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Oct 4, 2022
… allowed resources (#485) - [ ] Regenerate this pull request now. AssuredWorkload monitoring is a new feature which provides apis to fetch compliance violation for AssuredWorkloads. It also provides an api to acknowledge an unresolved violation. RestrictAllowedResources api allows restricting list of available resources in Workload environment. Committer: @ViswasK PiperOrigin-RevId: 477959383 Source-Link: https://togithub.com/googleapis/googleapis/commit/0cad78c955be529d8a0e95d4fc70077ec2772602 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/3052e0d7ac989bc571fb305894ada8525d1f248e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzA1MmUwZDdhYzk4OWJjNTcxZmIzMDU4OTRhZGE4NTI1ZDFmMjQ4ZSJ9 chore(bazel): update protobuf to v3.21.7 PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9
github-actions bot
pushed a commit
to renovate-bot/google-cloud-java
that referenced
this issue
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](https://togithub.com/googleapis/java-assured-workloads/compare/v2.2.1...v2.3.0) (2022-10-03) ### Features * Add apis for AssuredWorkload monitoring feature and to restrict allowed resources ([googleapis#485](https://togithub.com/googleapis/java-assured-workloads/issues/485)) ([f7a3fd6](https://togithub.com/googleapis/java-assured-workloads/commit/f7a3fd6ef108d6a35fc6d5810d9bfc328cc7befa)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
…onfig to v1.5.4 (#485) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.3` -> `1.5.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/compatibility-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/confidence-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.4`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​154-httpsgithubcomgoogleapisjava-shared-configcomparev153v154-2022-10-19) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.3...v1.5.4) ##### Dependencies - Update auto-value-annotation.version to v1.10 ([#​521](https://togithub.com/googleapis/java-shared-config/issues/521)) ([601235c](https://togithub.com/googleapis/java-shared-config/commit/601235c32b6f1233d81a27788f6691cda05787af)) - Update dependency com.puppycrawl.tools:checkstyle to v10.3.2 ([#​501](https://togithub.com/googleapis/java-shared-config/issues/501)) ([2b2c611](https://togithub.com/googleapis/java-shared-config/commit/2b2c611815cafd1809e27c769577ae55d481a170)) - Update dependency com.puppycrawl.tools:checkstyle to v10.3.3 ([#​510](https://togithub.com/googleapis/java-shared-config/issues/510)) ([8d7f75d](https://togithub.com/googleapis/java-shared-config/commit/8d7f75de442cb3a274004faae430e9edf60730f3)) - Update dependency com.puppycrawl.tools:checkstyle to v10.3.4 ([#​517](https://togithub.com/googleapis/java-shared-config/issues/517)) ([1119ba2](https://togithub.com/googleapis/java-shared-config/commit/1119ba29e4fe3a74a58c18961c3431570186cc27)) - Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.14 ([#​515](https://togithub.com/googleapis/java-shared-config/issues/515)) ([779a239](https://togithub.com/googleapis/java-shared-config/commit/779a2398f1310a2f23555dc5c861a5203364d7a1)) - Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.15 ([#​522](https://togithub.com/googleapis/java-shared-config/issues/522)) ([5dd225d](https://togithub.com/googleapis/java-shared-config/commit/5dd225dc5a66562c8496366986ef9dc401d9be92)) - Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.14 ([#​516](https://togithub.com/googleapis/java-shared-config/issues/516)) ([5605094](https://togithub.com/googleapis/java-shared-config/commit/56050943045d5e3d94c8598791c695d3fefcfef0)) - Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.15 ([#​523](https://togithub.com/googleapis/java-shared-config/issues/523)) ([45752ad](https://togithub.com/googleapis/java-shared-config/commit/45752ad7083f07d2ce81a23ea930aa9737473940)) - Update dependency org.junit.vintage:junit-vintage-engine to v5.9.1 ([#​514](https://togithub.com/googleapis/java-shared-config/issues/514)) ([60c000c](https://togithub.com/googleapis/java-shared-config/commit/60c000c3736288b98382aae79eb21a5cb15258fb)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDAuNSIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC41In0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some page-based cursor services, such as
gcloud-java-storage
andgcloud-java-resourcemanager
, currently have duplicated code for theBasePageFetcher
. We should refactor theBasePageFetcher
code to be ingcloud-java-core
. We can use Generics for the specific Options type O and provide an abstract method to return the PAGE_TOKEN option.The text was updated successfully, but these errors were encountered: