Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a unified way to set service options for both ServiceApi classes and handwritten service wrappers. #388

Closed
garrettjonesgoogle opened this issue Nov 17, 2015 · 1 comment
Closed

Create a unified way to set service options for both ServiceApi classes and handwritten service wrappers. #388

garrettjonesgoogle opened this issue Nov 17, 2015 · 1 comment
Assignees
@garrettjonesgoogle
Labels
api: core 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@garrettjonesgoogle
Copy link
Member

  • ServiceApi classes currently use ServiceApiSettings
  • handwritten service wrappers currently use ServiceOptions

We should create a unified way to configure these.
@garrettjonesgoogle garrettjonesgoogle mentioned this issue Nov 17, 2015
Merged
@garrettjonesgoogle
Copy link
Member Author

This would be a breaking change to GA clients at this point, so we aren't going to do it. Closing out the issue.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
github-actions bot pushed a commit that referenced this issue Jun 21, 2022
@gcf-owl-bot
chore: Integrate new gapic-generator-java and rules_gapic (#388)
6d95957 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 454027580

Source-Link: googleapis/googleapis@1b22277

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
@release-please
chore(master): release 0.118.10 (googleapis#388)
79b7e4a 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.118.10](https://www.github.com/googleapis/java-resourcemanager/compare/v0.118.9...v0.118.10) (2021-02-26)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.20.0 ([googleapis#387](https://www.github.com/googleapis/java-resourcemanager/issues/387)) ([0b91c20](https://www.github.com/googleapis/java-resourcemanager/commit/0b91c20bb49973d5752c83aef9701aaf43bd2558))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Jul 1, 2022
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
4b3c350 
…onfig to v1.2.4 (#388)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.2.2` -> `1.2.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/compatibility-slim/1.2.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/confidence-slim/1.2.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.2.4`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;124-httpswwwgithubcomgoogleapisjava-shared-configcomparev123v124-2022-01-06)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.3...v1.2.4)

### [`v1.2.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;123-httpswwwgithubcomgoogleapisjava-shared-configcomparev122v123-2022-01-04)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.2...v1.2.3)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).
github-actions bot pushed a commit that referenced this issue Aug 16, 2022
@renovate-bot
build(deps): update dependency org.apache.maven.plugins:maven-project…
120cb00 
…-info-reports-plugin to v3.4.1 (#388)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-area120-tables).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjAuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE2MC4xIn0=-->
github-actions bot pushed a commit that referenced this issue Oct 4, 2022
@release-please
chore(main): release 1.4.4 (#403)
22c4b3c 
🤖 I have created a release *beep* *boop*
---


## [1.4.4](https://togithub.com/googleapis/java-accesscontextmanager/compare/v1.4.3...v1.4.4) (2022-10-03)


### Dependencies

* Update dependency cachetools to v5 ([#401](https://togithub.com/googleapis/java-accesscontextmanager/issues/401)) ([5b95e04](https://togithub.com/googleapis/java-accesscontextmanager/commit/5b95e0409186acc96326cb1419749d1968d09747))
* Update dependency certifi to v2022.9.24 ([#381](https://togithub.com/googleapis/java-accesscontextmanager/issues/381)) ([2006334](https://togithub.com/googleapis/java-accesscontextmanager/commit/20063345f9b41bf9d1f8dad3c8ee5b01e3128b7c))
* Update dependency charset-normalizer to v2.1.1 ([#385](https://togithub.com/googleapis/java-accesscontextmanager/issues/385)) ([a91ee95](https://togithub.com/googleapis/java-accesscontextmanager/commit/a91ee95a4d9aa0d803e410484a2ef0bf55bef5f1))
* Update dependency click to v8.1.3 ([#386](https://togithub.com/googleapis/java-accesscontextmanager/issues/386)) ([703e69c](https://togithub.com/googleapis/java-accesscontextmanager/commit/703e69c8ea5fc2e871ee846c85558f8bcf831ae7))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#405](https://togithub.com/googleapis/java-accesscontextmanager/issues/405)) ([aa35e73](https://togithub.com/googleapis/java-accesscontextmanager/commit/aa35e73690f828d7dfe830b381a83da782650e71))
* Update dependency gcp-releasetool to v1.8.8 ([#382](https://togithub.com/googleapis/java-accesscontextmanager/issues/382)) ([f6c2f5f](https://togithub.com/googleapis/java-accesscontextmanager/commit/f6c2f5f3052b17cb553c765a2285e946bcc22889))
* Update dependency google-api-core to v2.10.1 ([#387](https://togithub.com/googleapis/java-accesscontextmanager/issues/387)) ([9040055](https://togithub.com/googleapis/java-accesscontextmanager/commit/9040055d0f96b7bf3567e4bac4010364d0058eae))
* Update dependency google-auth to v2.12.0 ([#388](https://togithub.com/googleapis/java-accesscontextmanager/issues/388)) ([6d3241c](https://togithub.com/googleapis/java-accesscontextmanager/commit/6d3241cadcfc5ac81232ae495b5207add8d9f59d))
* Update dependency google-cloud-core to v2.3.2 ([#383](https://togithub.com/googleapis/java-accesscontextmanager/issues/383)) ([d3fe01b](https://togithub.com/googleapis/java-accesscontextmanager/commit/d3fe01bc618ffe0e826c052583714524cd049928))
* Update dependency google-cloud-storage to v2.5.0 ([#389](https://togithub.com/googleapis/java-accesscontextmanager/issues/389)) ([934a05e](https://togithub.com/googleapis/java-accesscontextmanager/commit/934a05e263d1bb8b1c94d2f478bf2f15723bd6f8))
* Update dependency google-crc32c to v1.5.0 ([#390](https://togithub.com/googleapis/java-accesscontextmanager/issues/390)) ([5268cb1](https://togithub.com/googleapis/java-accesscontextmanager/commit/5268cb1a04fd9e05d950d5c03871a81e60364d2a))
* Update dependency googleapis-common-protos to v1.56.4 ([#384](https://togithub.com/googleapis/java-accesscontextmanager/issues/384)) ([32b231e](https://togithub.com/googleapis/java-accesscontextmanager/commit/32b231eef7879a6a0d74b650df878e2c462f207e))
* Update dependency importlib-metadata to v4.12.0 ([#391](https://togithub.com/googleapis/java-accesscontextmanager/issues/391)) ([3fee2e5](https://togithub.com/googleapis/java-accesscontextmanager/commit/3fee2e55869b14014c2240ce78a60c5888c7e9ae))
* Update dependency jeepney to v0.8.0 ([#392](https://togithub.com/googleapis/java-accesscontextmanager/issues/392)) ([b8a3a7f](https://togithub.com/googleapis/java-accesscontextmanager/commit/b8a3a7f6fcb6b72f95241a6e8d6b1a152c5e59b9))
* Update dependency jinja2 to v3.1.2 ([#393](https://togithub.com/googleapis/java-accesscontextmanager/issues/393)) ([47bfa73](https://togithub.com/googleapis/java-accesscontextmanager/commit/47bfa73b387eccb7450b8e0f2a19a38bf28d49f3))
* Update dependency keyring to v23.9.3 ([#394](https://togithub.com/googleapis/java-accesscontextmanager/issues/394)) ([1f01a1b](https://togithub.com/googleapis/java-accesscontextmanager/commit/1f01a1b83e4cd45bc03458ae9629e4cbe4c8deec))
* Update dependency markupsafe to v2.1.1 ([#395](https://togithub.com/googleapis/java-accesscontextmanager/issues/395)) ([7077e38](https://togithub.com/googleapis/java-accesscontextmanager/commit/7077e38a1a6c87d3449e63ce89ce3a56d696a93f))
* Update dependency protobuf to v3.20.2 ([#396](https://togithub.com/googleapis/java-accesscontextmanager/issues/396)) ([d5df519](https://togithub.com/googleapis/java-accesscontextmanager/commit/d5df519d69768a54fd02fee3251ed3fc4d9cd9b3))
* Update dependency protobuf to v4 ([#402](https://togithub.com/googleapis/java-accesscontextmanager/issues/402)) ([fe4ac2f](https://togithub.com/googleapis/java-accesscontextmanager/commit/fe4ac2f28d55d887d8618d420df310645ca29046))
* Update dependency pyjwt to v2.5.0 ([#397](https://togithub.com/googleapis/java-accesscontextmanager/issues/397)) ([dd3fa88](https://togithub.com/googleapis/java-accesscontextmanager/commit/dd3fa88e32f6b0b4abc8be4eacfd509b83bd9671))
* Update dependency requests to v2.28.1 ([#398](https://togithub.com/googleapis/java-accesscontextmanager/issues/398)) ([3e55397](https://togithub.com/googleapis/java-accesscontextmanager/commit/3e55397a817d3937b2f50bb7245eda5319d29ae6))
* Update dependency typing-extensions to v4.3.0 ([#399](https://togithub.com/googleapis/java-accesscontextmanager/issues/399)) ([d0d77e2](https://togithub.com/googleapis/java-accesscontextmanager/commit/d0d77e24179689351ddf677b012c14f94e109346))
* Update dependency zipp to v3.8.1 ([#400](https://togithub.com/googleapis/java-accesscontextmanager/issues/400)) ([c40c50e](https://togithub.com/googleapis/java-accesscontextmanager/commit/c40c50edb7767e444cf7a158df513f15e7e6f644))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this issue Feb 1, 2023
@renovate-bot
deps: update dependency io.grpc:grpc-protobuf to v1.48.0 (#388)
5658416 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | `1.47.0` -> `1.48.0` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.0/compatibility-slim/1.47.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.0/confidence-slim/1.47.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>grpc/grpc-java</summary>

### [`v1.48.0`](https://togithub.com/grpc/grpc-java/compare/v1.47.0...v1.48.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels
api: core 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aozarov @garrettjonesgoogle @yoshi-automation