Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move credential provider up from ChannelProvider to ClientSettings #2034

Closed
6 tasks done
garrettjonesgoogle opened this issue May 4, 2017 · 5 comments
Closed
6 tasks done

Move credential provider up from ChannelProvider to ClientSettings #2034

garrettjonesgoogle opened this issue May 4, 2017 · 5 comments
Assignees
@tcoffee-google
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented May 4, 2017 •
edited by tcoffee-google
Loading

Currently in GAPIC clients, credentials have to be set on the channel. We should improve the credential customization experience because it's now possible to add credentials on a call-by-call basis in a non-experimental way through CallOptions in grpc. We should do the following:

  • Create a future callable type in gax which adds the credentials to the call
  • Add credentials provider to ClientSettings
  • Deprecate credentials provider on ChannelProvider
  • Make it work in streaming callable too
  • Add setCredentialProvider to Publisher/Subscriber in Pub/Sub
  • Regenerate GCJ
@garrettjonesgoogle garrettjonesgoogle added api: pubsub Issues related to the Pub/Sub API. Status: Beta Blocking labels May 4, 2017
@pongad pongad mentioned this issue May 8, 2017
Merged
pongad added a commit to googleapis/gax-java that referenced this issue May 22, 2017
@pongad
Move CredentialProvider up to ClientSettings (#305)
5830ace 
Updates googleapis/google-cloud-java#2034.

This commit should resolve the first 3 bullets in the
linked issue.

Major changes are:
- ClientContext is added to pull together channel, executor, and credentials,
  which are often needed together.
  This change will also simplify future work if more ClientSettings are added.
@tcoffee-google tcoffee-google added the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 22, 2017
@garrettjonesgoogle
Copy link
Member Author

@pongad is this all done?

@pongad
Copy link
Contributor

pongad commented May 30, 2017

We'll need to release gax and regen GCJ. The "manual code change" part is done though. Are we good releasing gax?

@garrettjonesgoogle garrettjonesgoogle added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 6, 2017
@tcoffee-google
Copy link
Contributor

#2114

@garrettjonesgoogle
Copy link
Member Author

The final closing of this issue depends on #2116 being completed - reopening.

@garrettjonesgoogle
Copy link
Member Author

Done fully in #2116 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcoffee-google tcoffee-google

Labels
api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pongad @garrettjonesgoogle @tcoffee-google