BigQuery - remove uses of jobs.query method. #1588
Assignees
Labels
api: bigquery
Issues related to the BigQuery API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Comments
shinfan
added
type: feature request
garrettjonesgoogle
added
the
priority: p1
github-actions bot
pushed a commit
that referenced
this issue
Sep 30, 2022
#242) …thon 3.6 (#1588) (#217)" This reverts commit f935ae3. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-apigee-connect/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
github-actions bot
pushed a commit
that referenced
this issue
Sep 30, 2022
#37) …thon 3.6 (#1588) (#13)" This reverts commit 9dc8ba4. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-beyondcorp-appgateways/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
github-actions bot
pushed a commit
that referenced
this issue
Sep 30, 2022
…#1588) (#966) * chore: pin versions of dependencies for compatibility with Python 3.6 * fix path of requirements file in synthtool Source-Link: googleapis/synthtool@69cdb47 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Diego Alonso Marquez Palacios <[email protected]>
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
…#1588) (#809) * chore: pin versions of dependencies for compatibility with Python 3.6 * fix path of requirements file in synthtool Source-Link: googleapis/synthtool@69cdb47 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
…#1588) (#932) * chore: pin versions of dependencies for compatibility with Python 3.6 * fix path of requirements file in synthtool Source-Link: googleapis/synthtool@69cdb47 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
…#1588) (#437) * chore: pin versions of dependencies for compatibility with Python 3.6 (#1588) * chore: pin versions of dependencies for compatibility with Python 3.6 * fix path of requirements file in synthtool Source-Link: googleapis/synthtool@69cdb47 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Diego Alonso Marquez Palacios <[email protected]>
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The jobs.query method should not be used in the client libraries.
Reasons: the query can time out, but it still might actually run, costing money & resources. Unless you poll for the results (not obvious you have to do this) you won't see them.
Also, the
jobs/queryAPI does not accept a job ID. This means that a retry on failure could result in duplicate queries being run, causing extra resource usage & charges.Proposal:
jobs/query. Instead usejobs/insert.BigQuery.query(QueryRequest). Providing a synchronous method without an explicit job ID is dangerous for the reasons listed above. Alternatively, we could generate a job ID client-side, which would protect against duplicate queries from retries from the client libraries.BigQuery.query(QueryRequest, JobId)so users can explicitly provide a job ID for safe retries (even against program crashes if they save the job ID somewhere -- important for really big/expensive queries).The text was updated successfully, but these errors were encountered: