Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary lines that reference SNAPSHOT BOM versions #10661

Closed
suztomo opened this issue Apr 4, 2024 · 0 comments · Fixed by #10682
Closed

Remove unnecessary lines that reference SNAPSHOT BOM versions #10661

suztomo opened this issue Apr 4, 2024 · 0 comments · Fixed by #10682
Assignees
@suztomo
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@suztomo
Copy link
Member

suztomo commented Apr 4, 2024

Remove these lines that are unnecessary.

~/google-cloud-java $ find . -name pom.xml |xargs grep SNAPSHOT
./java-video-intelligence/pom.xml:        <version>2.4.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-video-intelligence-bom:current} -->
./java-talent/pom.xml:        <version>2.6.1-SNAPSHOT</version> <!-- {x-version-update:google-cloud-talent-bom:current} -->


 84       <dependency>
 85         <groupId>com.google.cloud</groupId>
 86         <artifactId>google-cloud-video-intelligence-bom</artifactId>
 87         <version>2.4.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-video-intelligence-bom:current} -->
 88       </dependency>
 89     </dependencies>
 90   </dependencyManagement>
@suztomo suztomo self-assigned this Apr 4, 2024
@suztomo suztomo added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 11, 2024
suztomo added a commit that referenced this issue Apr 11, 2024
@suztomo
chore: fixing the bad reference for "-bom" version key
91a0b92 
Release Please's versions.txt does not have "-bom" version key.
These values have never been updated and fortunately the BOM
versions in a client library parent pom do not have any effect
for customers use of the libraries.

Fixes #10661
@suztomo suztomo mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suztomo suztomo

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fixing the bad reference for "-bom" version key googleapis/google-cloud-java
1 participant
@suztomo