StorageImpl.signUrl generates invalid URLs for objects names with leading / #1006
Assignees
Labels
api: storage
Issues related to the Cloud Storage API.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
mziccard
added
api: storage
|
Hi @clementdenis, nice catch! Would you mind sending a PR? Your patch looks good to me. |
|
Done! See #1008 |
github-actions bot
pushed a commit
that referenced
this issue
Aug 9, 2022
…14.1 (#1006) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.13.6` -> `2.14.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.14.1`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2141-httpsgithubcomgoogleapisjava-bigquerycomparev2140v2141-2022-07-27) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.0...v2.14.1) ##### Dependencies - update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#​2183](https://togithub.com/googleapis/java-bigquery/issues/2183)) ([f8325cf](https://togithub.com/googleapis/java-bigquery/commit/f8325cff22af3f087b23d6376ab96e78648efd00)) ### [`v2.14.0`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2140-httpsgithubcomgoogleapisjava-bigquerycomparev2138v2140-2022-07-22) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.13.8...v2.14.0) ##### Features - Add decimal target type ([#​2166](https://togithub.com/googleapis/java-bigquery/issues/2166)) ([ebbd8f5](https://togithub.com/googleapis/java-bigquery/commit/ebbd8f52853d3c0ca918a47d826474cc5825a58a)) - **bigquery:** enable use of GEOGRAPHY query params ([#​2158](https://togithub.com/googleapis/java-bigquery/issues/2158)) ([b19ad76](https://togithub.com/googleapis/java-bigquery/commit/b19ad767a53a9bd5d14b4cb36716cbb1c7b44ed6)) ##### Bug Fixes - Add query dryRun logic to get the schema when null schema is returned from the backend ([#​2106](https://togithub.com/googleapis/java-bigquery/issues/2106)) ([c98d22b](https://togithub.com/googleapis/java-bigquery/commit/c98d22b2b4f45e20d7d0666c5342cdbfadd30bde)) - enable longpaths support for windows test ([#​1485](https://togithub.com/googleapis/java-bigquery/issues/1485)) ([#​2164](https://togithub.com/googleapis/java-bigquery/issues/2164)) ([e18b9f8](https://togithub.com/googleapis/java-bigquery/commit/e18b9f8b4d2f194577b1710ad64710fe0f3d88d9)) - **java:** make field accessible to address Java 17 issue with arrow ([#​2165](https://togithub.com/googleapis/java-bigquery/issues/2165)) ([d605b81](https://togithub.com/googleapis/java-bigquery/commit/d605b8149954e79c05461630915b674e11793889)) ##### Dependencies - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 ([#​2160](https://togithub.com/googleapis/java-bigquery/issues/2160)) ([970135b](https://togithub.com/googleapis/java-bigquery/commit/970135bec33b831925476855da9a84c34311068d)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#​2161](https://togithub.com/googleapis/java-bigquery/issues/2161)) ([3507bf7](https://togithub.com/googleapis/java-bigquery/commit/3507bf7c9fc2aef299d06d9771cfcc06e3080b87)) ### [`v2.13.8`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2138-httpsgithubcomgoogleapisjava-bigquerycomparev2137v2138-2022-07-01) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.13.7...v2.13.8) ##### Dependencies - update dependency com.google.cloud:google-cloud-storage to v2.9.0 ([#​2149](https://togithub.com/googleapis/java-bigquery/issues/2149)) ([a07c714](https://togithub.com/googleapis/java-bigquery/commit/a07c714cb90c7ff62a43f7500abe8d54a5cd0936)) ### [`v2.13.7`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2137-httpsgithubcomgoogleapisjava-bigquerycomparev2136v2137-2022-06-29) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.13.6...v2.13.7) ##### Dependencies - update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.8.4 ([#​2140](https://togithub.com/googleapis/java-bigquery/issues/2140)) ([c7ef597](https://togithub.com/googleapis/java-bigquery/commit/c7ef597832505e6c05adb38ac1db5dd15e32d024)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
github-actions bot
pushed a commit
that referenced
this issue
Aug 9, 2022
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [3.2.0](googleapis/java-aiplatform@v3.1.0...v3.2.0) (2022-08-09) ### Features * add a DeploymentResourcePool API resource_definition ([#997](googleapis/java-aiplatform#997)) ([82551d8](googleapis/java-aiplatform@82551d8)) * add DeploymentResourcePool in aiplatform v1beta1 deployment_resource_pool.proto ([#998](googleapis/java-aiplatform#998)) ([76dc64f](googleapis/java-aiplatform@76dc64f)) * add DeploymentResourcePoolService in aiplatform v1beta1 deployment_resource_pool_service.proto ([76dc64f](googleapis/java-aiplatform@76dc64f)) * add shared_resources for supported prediction_resources ([82551d8](googleapis/java-aiplatform@82551d8)) * add SHARED_RESOURCES to DeploymentResourcesType in aiplatform v1beta1 model.proto ([76dc64f](googleapis/java-aiplatform@76dc64f)) * added SHARED_RESOURCES enum to aiplatform v1 model.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) * DeploymentResourcePool and DeployementResourcePoolService added to aiplatform v1beta1 model.proto (cl/463147866) ([301cfb0](googleapis/java-aiplatform@301cfb0)) * making network arg optional in aiplatform v1 custom_job.proto ([#999](googleapis/java-aiplatform#999)) ([301cfb0](googleapis/java-aiplatform@301cfb0)) * making network arg optional in aiplatform v1beta1 custom_job.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) * **samples:** add all feature samples ([#980](googleapis/java-aiplatform#980)) ([8c2a485](googleapis/java-aiplatform@8c2a485)) * **samples:** add all feature values samples ([#981](googleapis/java-aiplatform#981)) ([2d4e6fe](googleapis/java-aiplatform@2d4e6fe)) ### Bug Fixes * declaring test-scope artifact as runtime ([#1014](googleapis/java-aiplatform#1014)) ([6c47c65](googleapis/java-aiplatform@6c47c65)) ### Documentation * doc edits to aiplatform v1 dataset_service.proto, job_service.proto, model_service.proto, pipeline_service.proto, saved_query.proto, study.proto, types.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) * doc edits to aiplatform v1beta1 job_service.proto, model_service.proto, pipeline_service.proto, saved_query.proto, study.proto, types.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) ### Dependencies * update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.17.0 ([#1003](googleapis/java-aiplatform#1003)) ([b793732](googleapis/java-aiplatform@b793732)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1006](googleapis/java-aiplatform#1006)) ([6bb8982](googleapis/java-aiplatform@6bb8982)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1009](googleapis/java-aiplatform#1009)) ([8cca8b5](googleapis/java-aiplatform@8cca8b5)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1000](googleapis/java-aiplatform#1000)) ([c93de30](googleapis/java-aiplatform@c93de30)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1004](googleapis/java-aiplatform#1004)) ([dd52cad](googleapis/java-aiplatform@dd52cad)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1005](googleapis/java-aiplatform#1005)) ([60e2f76](googleapis/java-aiplatform@60e2f76)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1008](googleapis/java-aiplatform#1008)) ([9a2fe64](googleapis/java-aiplatform@9a2fe64)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1010](googleapis/java-aiplatform#1010)) ([3c2ac16](googleapis/java-aiplatform@3c2ac16)) * update dependency com.google.code.gson:gson to v2.9.1 ([#1001](googleapis/java-aiplatform#1001)) ([a6ffed4](googleapis/java-aiplatform@a6ffed4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The generated URL contains zero-chars.
The problem is probably here: master...clementdenis:patch-1
The method should either reject object names leading slash, or handle them correctly.
The text was updated successfully, but these errors were encountered: