Skip to content

Commit

Permalink
BigQuery: correct ITBigQueryTest (#3303)
Browse files Browse the repository at this point in the history
Test asserts consistent values for all rows within a table, but the
sample data used for generating tables was inconsistent between rows.
  • Loading branch information
shollyman authored and pongad committed May 22, 2018
1 parent 86be7e5 commit bb092a0
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ public class ITBigQueryTest {
+ " },"
+ " \"IntegerField\": \"3\","
+ " \"FloatField\": \"1.2\","
+ " \"NumericField\": \"3.14\""
+ " \"NumericField\": \"123456.789012345\""
+ "}\n"
+ "{"
+ " \"TimestampField\": \"2014-08-19 07:41:35.220 -05:00\","
Expand Down Expand Up @@ -818,7 +818,7 @@ public void testListAllTableData() {
assertEquals(true, recordCell.getRecordValue().get(3).getBooleanValue());
assertEquals(3, integerCell.getLongValue());
assertEquals(1.2, floatCell.getDoubleValue(), 0.0001);
assertEquals(new BigDecimal("123456789.123456789"), numericCell.getNumericValue());
assertEquals(new BigDecimal("123456.789012345"), numericCell.getNumericValue());
rowCount++;
}
assertEquals(2, rowCount);
Expand Down Expand Up @@ -1235,7 +1235,7 @@ public void testInsertFromFile() throws InterruptedException, IOException, Timeo
assertEquals(true, recordCell.getRecordValue().get(3).getBooleanValue());
assertEquals(3, integerCell.getLongValue());
assertEquals(1.2, floatCell.getDoubleValue(), 0.0001);
assertEquals(new BigDecimal("123456789.123456789"), floatCell.getNumericValue());
assertEquals(new BigDecimal("123456.789012345"), numericCell.getNumericValue());
rowCount++;
}
assertEquals(2, rowCount);
Expand Down

0 comments on commit bb092a0

Please sign in to comment.