Merge pull request #293 from mziccard/remove-storage-todos

Remove storage todos
googleapis · Oct 26, 2015 · 6e25709 · 6e25709
2 parents 33e932e + fe98cb4
commit 6e25709
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java b/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java
@@ -293,7 +293,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
       Map<Option, ?> targetOptions) throws StorageException {
     ComposeRequest request = new ComposeRequest();
     if (target.getContentType() == null) {
-      // todo: remove once this is no longer requirement (b/20681287).
       target.setContentType("application/octet-stream");
     }
     request.setDestination(target);
@@ -311,7 +310,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
     }
     request.setSourceObjects(sourceObjects);
     try {
-      // todo: missing setProjection (b/20659000)
       return storage.objects()
           .compose(target.getBucket(), target.getName(), request)
           .setIfMetagenerationMatch(IF_METAGENERATION_MATCH.getLong(targetOptions))
@@ -435,7 +433,6 @@ public byte[] read(StorageObject from, Map<Option, ?> options, long position, in
           .setIfGenerationMatch(IF_GENERATION_MATCH.getLong(options))
           .setIfGenerationNotMatch(IF_GENERATION_NOT_MATCH.getLong(options));
       MediaHttpDownloader downloader = req.getMediaHttpDownloader();
-      // todo: Fix int casting (https://github.com/google/google-api-java-client/issues/937)
       downloader.setContentRange(position, (int) position + bytes);
       downloader.setDirectDownloadEnabled(true);
       ByteArrayOutputStream output = new ByteArrayOutputStream();

diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java b/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java
@@ -102,8 +102,6 @@ public RetryResult beforeEval(Exception exception) {
   StorageImpl(StorageOptions options) {
     super(options);
     storageRpc = options.storageRpc();
-    // todo: provide rewrite - https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite
-    // todo: check if we need to expose https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert vs using bucket update/patch
   }
 
   @Override