Clean up MessageDispatcher by changing processOutstandingBatches to e…

…xplicitly loop instead of while(true) with breaks. There is now only 1 explicit return and 1 runtime error. (#4619)
googleapis · Mar 4, 2019 · 5e0acc0 · 5e0acc0
1 parent 4517817
commit 5e0acc0
Showing 1 changed file with 24 additions and 34 deletions.
diff --git a/...ients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java b/...ients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java
@@ -371,41 +371,31 @@ public void processReceivedMessages(List<ReceivedMessage> messages, Runnable don
     processOutstandingBatches();
   }
 
-  public void processOutstandingBatches() {
-    while (true) {
-      boolean batchDone = false;
-      Runnable batchCallback = null;
-      OutstandingMessage outstandingMessage;
-      synchronized (outstandingMessageBatches) {
-        OutstandingMessageBatch nextBatch = outstandingMessageBatches.peek();
-        if (nextBatch == null) {
-          return;
-        }
-        outstandingMessage = nextBatch.messages.peek();
-        if (outstandingMessage == null) {
-          return;
-        }
-        try {
-          // This is a non-blocking flow controller.
-          flowController.reserve(
-              1, outstandingMessage.receivedMessage().getMessage().getSerializedSize());
-        } catch (FlowController.MaxOutstandingElementCountReachedException
-            | FlowController.MaxOutstandingRequestBytesReachedException flowControlException) {
-          return;
-        } catch (FlowControlException unexpectedException) {
-          throw new IllegalStateException("Flow control unexpected exception", unexpectedException);
-        }
-        nextBatch.messages.poll(); // We got a hold to the message already.
-        batchDone = nextBatch.messages.isEmpty();
-        if (batchDone) {
-          outstandingMessageBatches.poll();
-          batchCallback = nextBatch.doneCallback;
+  private void processOutstandingBatches() {
+    synchronized (outstandingMessageBatches) {
+      for (OutstandingMessageBatch nextBatch = outstandingMessageBatches.poll();
+          nextBatch != null;
+          nextBatch = outstandingMessageBatches.poll()) {
+        for (OutstandingMessage nextMessage = nextBatch.messages.poll();
+            nextMessage != null;
+            nextMessage = nextBatch.messages.poll()) {
+          try {
+            // This is a non-blocking flow controller.
+            flowController.reserve(1, nextMessage.receivedMessage.getMessage().getSerializedSize());
+          } catch (FlowController.MaxOutstandingElementCountReachedException
+              | FlowController.MaxOutstandingRequestBytesReachedException flowControlException) {
+            // Unwind previous changes in the batches outstanding.
+            nextBatch.messages.addFirst(nextMessage);
+            outstandingMessageBatches.addFirst(nextBatch);
+            return;
+          } catch (FlowControlException unexpectedException) {
+            throw new IllegalStateException(
+                "Flow control unexpected exception", unexpectedException);
+          }
+          processOutstandingMessage(
+              nextMessage.receivedMessage.getMessage(), nextMessage.ackHandler);
         }
-      }
-      processOutstandingMessage(
-          outstandingMessage.receivedMessage.getMessage(), outstandingMessage.ackHandler);
-      if (batchDone) {
-        batchCallback.run();
+        nextBatch.doneCallback.run();
       }
     }
   }