Skip to content

Commit

Permalink
Remove final from immutable resource classes
Browse files Browse the repository at this point in the history
  • Loading branch information
mziccard committed Mar 15, 2016
1 parent c41ad14 commit 484071c
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
*
* @see <a href="https://cloud.google.com/compute/docs/reference/latest/diskTypes">Disk Types</a>
*/
public final class DiskType implements Serializable {
public class DiskType implements Serializable {

static final Function<com.google.api.services.compute.model.DiskType, DiskType> FROM_PB_FUNCTION =
new Function<com.google.api.services.compute.model.DiskType, DiskType>() {
Expand Down Expand Up @@ -186,12 +186,12 @@ public String toString() {
}

@Override
public int hashCode() {
public final int hashCode() {
return Objects.hash(diskTypeId);
}

@Override
public boolean equals(Object obj) {
public final boolean equals(Object obj) {
return obj instanceof DiskType && Objects.equals(toPb(), ((DiskType) obj).toPb());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
*
* @see <a href="https://cloud.google.com/compute/docs/reference/latest/licenses">Licenses</a>
*/
public final class License implements Serializable {
public class License implements Serializable {

private static final long serialVersionUID = 6907923910319640363L;

Expand Down Expand Up @@ -65,12 +65,12 @@ public String toString() {
}

@Override
public int hashCode() {
public final int hashCode() {
return Objects.hash(licenseId);
}

@Override
public boolean equals(Object obj) {
public final boolean equals(Object obj) {
return obj instanceof License && Objects.equals(toPb(), ((License) obj).toPb());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
*
* @see <a href="https://cloud.google.com/compute/docs/machine-types">Machine Types</a>
*/
public final class MachineType implements Serializable {
public class MachineType implements Serializable {

static final Function<com.google.api.services.compute.model.MachineType, MachineType>
FROM_PB_FUNCTION =
Expand Down Expand Up @@ -242,12 +242,12 @@ public String toString() {
}

@Override
public int hashCode() {
public final int hashCode() {
return Objects.hash(machineTypeId);
}

@Override
public boolean equals(Object obj) {
public final boolean equals(Object obj) {
return obj instanceof MachineType && Objects.equals(toPb(), ((MachineType) obj).toPb());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*
* @see <a href="https://cloud.google.com/compute/docs/zones">Region and Zones</a>
*/
public final class Region implements Serializable {
public class Region implements Serializable {

static final Function<com.google.api.services.compute.model.Region, Region> FROM_PB_FUNCTION =
new Function<com.google.api.services.compute.model.Region, Region>() {
Expand Down Expand Up @@ -306,12 +306,12 @@ public String toString() {
}

@Override
public int hashCode() {
public final int hashCode() {
return Objects.hash(regionId);
}

@Override
public boolean equals(Object obj) {
public final boolean equals(Object obj) {
return obj instanceof Region && Objects.equals(toPb(), ((Region) obj).toPb());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*
* @see <a href="https://cloud.google.com/compute/docs/zones">Region and Zones</a>
*/
public final class Zone implements Serializable {
public class Zone implements Serializable {

static final Function<com.google.api.services.compute.model.Zone, Zone> FROM_PB_FUNCTION =
new Function<com.google.api.services.compute.model.Zone, Zone>() {
Expand Down Expand Up @@ -325,12 +325,12 @@ public String toString() {
}

@Override
public int hashCode() {
public final int hashCode() {
return Objects.hash(zoneId);
}

@Override
public boolean equals(Object obj) {
public final boolean equals(Object obj) {
return obj instanceof Zone && Objects.equals(toPb(), ((Zone) obj).toPb());
}

Expand Down

0 comments on commit 484071c

Please sign in to comment.