4107: Close response body after request

googleapis · Nov 30, 2018 · 3550f81 · 3550f81
1 parent a7703f2
commit 3550f81
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/...ts/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java b/...ts/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java
@@ -681,14 +681,19 @@ public void write(String uploadId, byte[] toWrite, int toWriteOffset, long destO
       int code;
       String message;
       IOException exception = null;
+      HttpResponse response = null;
       try {
-        HttpResponse response = httpRequest.execute();
+        response = httpRequest.execute();
         code = response.getStatusCode();
         message = response.getStatusMessage();
       } catch (HttpResponseException ex) {
         exception = ex;
         code = ex.getStatusCode();
         message = ex.getStatusMessage();
+      } finally {
+        if (response != null ) {
+          response.disconnect();
+        }
       }
       if (!last && code != 308 || last && !(code == 200 || code == 201)) {
         if (exception != null) {