Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: freeze OpenTelemetry at 1.24.0 #9808

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Apr 18, 2024

  • go.opentelemetry.io/otel 1.25.0 and submodules no longer support Go 1.20.
  • Stop updating Open Telemetry until our runtime support catches up.

Got this error in vet in the latest google-cloud-go renovate PR #9724:

Error: ../../../[go/pkg/mod/](http://goto.google.com/pkg/mod/go.opentelemetry.io/otel)[go.opentelemetry.io/otel](http://go.opentelemetry.io/[email protected]/attribute/set.go:7:2)[@v1.25.0/attribute/set.go:7:2](http://go.opentelemetry.io/[email protected]/attribute/set.go:7:2): package cmp is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/cmp)
[1391](https://github.com/googleapis/google-cloud-go/actions/runs/8743459156/job/23994039449?pr=9724#step:5:1392)note: imported by a module that requires go 1.21 (compile)
[1392](https://github.com/googleapis/google-cloud-go/actions/runs/8743459156/job/23994039449?pr=9724#step:5:1393)Error: ../../../[go/pkg/mod/](http://goto.google.com/pkg/mod/go.opentelemetry.io/otel)[go.opentelemetry.io/otel](http://go.opentelemetry.io/[email protected]/attribute/set.go:10:2)[@v1.25.0/attribute/set.go:10:2](http://go.opentelemetry.io/[email protected]/attribute/set.go:10:2): package slices is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/slices)
[1393](https://github.com/googleapis/google-cloud-go/actions/runs/8743459156/job/23994039449?pr=9724#step:5:1394)note: imported by a module that requires go 1.21 (compile)

* go.opentelemetry.io/otel 1.25.0 and submodules no longer support Go 1.20
* Stop updating Open Telemetry until our runtime support catches up.
@quartzmo quartzmo requested a review from a team as a code owner April 18, 2024 20:47
@quartzmo quartzmo requested a review from a team as a code owner April 18, 2024 21:17
@quartzmo quartzmo merged commit 573bfaa into googleapis:main Apr 18, 2024
10 checks passed
@quartzmo quartzmo deleted the pin-otel-1240 branch April 18, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants