Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): update dependencies #9794

Merged
merged 3 commits into from
Apr 17, 2024
Merged

chore(all): update dependencies #9794

merged 3 commits into from
Apr 17, 2024

Conversation

quartzmo
Copy link
Member

go get google.golang.org/api@latest && go work sync

google.golang.org/api v0.172.0 -> v0.174.0
google.golang.org/genproto v0.0.0-20240213162025-012b6fc9bca9 -> v0.0.0-20240401170217-c3f982113cda
google.golang.org/grpc v1.62.1 -> v1.63.0
...

@quartzmo
chore(all): update dependencies
5ad57e1 
go get google.golang.org/api@latest && go work sync
@quartzmo quartzmo requested review from jba, eliben, a team and shollyman as code owners April 17, 2024 20:54
@quartzmo quartzmo requested a review from daniel-sanche April 17, 2024 20:54
codyoss
codyoss reviewed Apr 17, 2024
View reviewed changes
internal/postprocessor/go.mod Outdated
go 1.20
go 1.21

toolchain go1.22.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should figure out what dep requires 1.22 and remove it or downgrade for now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you bump this to 1.21 you can remove the toolchain

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ran with 1.20

@quartzmo
Copy link
Member Author 

=== RUN   TestSampleRowKeys_Retry_WithRoutingCookie
    samplerowkeys_test.go:281: 
        	Error Trace:	/home/runner/work/google-cloud-go/google-cloud-go/cloud-bigtable-clients-test/tests/samplerowkeys_test.go:281
        	Error:      	Should NOT be empty, but was []
        	Test:       	TestSampleRowKeys_Retry_WithRoutingCookie
--- FAIL: TestSampleRowKeys_Retry_WithRoutingCookie (0.05s)
=== RUN   TestSampleRowKeys_Retry_WithRetryInfo
    samplerowkeys_test.go:321: 
        	Error Trace:	/home/runner/work/google-cloud-go/google-cloud-go/cloud-bigtable-clients-test/tests/samplerowkeys_test.go:321
        	Error:      	Should be true
        	Test:       	TestSampleRowKeys_Retry_WithRetryInfo
--- FAIL: TestSampleRowKeys_Retry_WithRetryInfo (0.10s)
FAIL
exit status 1
FAIL	github.com/googleapis/cloud-bigtable-clients-test/tests	42.144s

@quartzmo quartzmo enabled auto-merge (squash) April 17, 2024 21:56
@quartzmo quartzmo merged commit ef22468 into googleapis:main Apr 17, 2024
327 of 329 checks passed
@quartzmo quartzmo deleted the update-deps branch April 17, 2024 22:29
@bhshkh bhshkh mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@jba jba Awaiting requested review from jba jba is a code owner

@eliben eliben Awaiting requested review from eliben eliben is a code owner

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche daniel-sanche is a code owner automatically assigned from googleapis/api-logging

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quartzmo @codyoss