Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/postprocessor): process new mods #9567

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Mar 12, 2024

When initializing a new go.mod file, add it to the list of modules that would otherwise be derived from the OwlBot PR body (that is actually processed by the post processor!) so that it is processed (e.g. tidied) with the rest of the modules changed in the PR.

I explicitly didn't change the logic to tidy modules based on which modules were changed b.c I don't want to make too big a change without having a clear idea of the impact. In the meantime, this fix will keep things ticking over with a little bit less manual toil.

Fixes #9560

@noahdietz noahdietz requested a review from a team as a code owner March 12, 2024 23:00
@noahdietz
Copy link
Contributor Author

Verified locally that the new go.mod is populated and summed appropriately.

@noahdietz noahdietz merged commit 023b8dd into googleapis:main Mar 13, 2024
9 checks passed
@noahdietz noahdietz deleted the post-tidy branch March 13, 2024 01:15
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal/postprocessor: not tidying the modules as it should be
2 participants