feat(vertexai): use pointers for GenerationConfig fields #9182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the fields that are pointers in in the GenerationConfig proto be pointers in the veneer as well. This fixes a bug with temperature: when it was a float32, we intpreted zero as nil. This meant it was impossible to set a zero temperature: attempting to do so would transmit a nil Temperature to the server, which the server would interpret as the default. We changed the other fields for consistency. To make it convenient to set these pointer fields, provide a generic `Ptr` function as well as a Set method for each field. Also, remove the model config defaults, which no longer seem to be necessary.
jba
added
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
eliben
approved these changes
Dec 16, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 17, 2023
🤖 I have created a release *beep* *boop* --- ## [0.6.0](https://togithub.com/googleapis/google-cloud-go/compare/vertexai/v0.5.2...vertexai/v0.6.0) (2023-12-17) ### Features * **vertexai:** Use pointers for GenerationConfig fields ([#9182](https://togithub.com/googleapis/google-cloud-go/issues/9182)) ([91990c1](https://togithub.com/googleapis/google-cloud-go/commit/91990c1746945c7f0548df972acf1498b165beb9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the fields that are pointers in in the GenerationConfig proto be
pointers in the veneer as well.
This fixes a bug with temperature: when it was a float32, we intpreted zero as nil.
This meant it was impossible to set a zero temperature: attempting to do
so would transmit a nil Temperature to the server, which the server
would interpret as the default. We changed the other fields for consistency.
To make it convenient to set these pointer fields, provide a generic
Ptrfunctionas well as a Set method for each field.
Also, remove the model config defaults, which no longer seem to be necessary.